Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally use std::invoke_result_t #105

Merged
merged 2 commits into from
Jun 8, 2022
Merged

Conditionally use std::invoke_result_t #105

merged 2 commits into from
Jun 8, 2022

Conversation

tsnorri
Copy link

@tsnorri tsnorri commented Jun 7, 2022 •
edited
Loading

  • std::result_of has been deprecated in C++17 and removed in C++20.

@tsnorri
Conditionally use std::invoke_result_t
291c4ab 
- std::result_of has been deprecated in C++17 and removed in C++20.
@tsnorri
Copy link
Author

tsnorri commented Jun 7, 2022 •
edited
Loading

According to P0604R0, __cpp_lib_is_invocable is the correct feature testing macro to use.

@eseiler
Copy link
Collaborator

eseiler commented Jun 8, 2022

Thanks for your contribution!

Since we aim at cpp17, I'm gonna go ahead and remove the check and just use the cpp17 version (and see if the CI accepts this).

eseiler
eseiler reviewed Jun 8, 2022
View reviewed changes
include/sdsl/iterators.hpp Outdated Show resolved Hide resolved
include/sdsl/iterators.hpp Outdated Show resolved Hide resolved
@eseiler eseiler enabled auto-merge (squash) June 8, 2022 09:12
@eseiler eseiler merged commit 6fa35eb into xxsds:master Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eseiler eseiler eseiler left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsnorri @eseiler