Skip to content

Commit

Permalink
[Misc] Don't push to Sonarcloud since it requires building with Java 17
Browse files Browse the repository at this point in the history
* Fix build
  • Loading branch information
vmassol committed Nov 16, 2023
1 parent 5675855 commit f8ab461
Showing 1 changed file with 6 additions and 8 deletions.
14 changes: 6 additions & 8 deletions Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -110,21 +110,19 @@ def builds = [
'Quality' : {
// Run the quality checks.
// Sonar notes:
// - we need sonar:sonar to perform the analysis
// - we need sonar = true to push the analysis to Sonarcloud
// - we need sonar:sonar to perform the analysis and push the results to Sonarcloud
// - we need jacoco:report to execute jacoco and compute test coverage
// - we need -Pcoverage and -Dxwiki.jacoco.itDestFile to tell Jacoco to compute a single global Jacoco
// coverage for the full reactor (so that the coverage percentage computed takes into account module tests
// which cover code in other modules)
build(
name: 'Quality',
goals: 'clean install jacoco:report sonar:sonar',
// We don't run sonar and push to sonarcloud since it requires Java 17 since the 15th of November and that
// would force us to make the 14.10.x branch build with Java 17 which is not easy to do. This will autofix
// itself when the next LTS is 15.10.x.
goals: 'clean install jacoco:report',
profiles: 'quality,legacy,coverage',
properties: '-Dxwiki.jacoco.itDestFile=`pwd`/target/jacoco-it.exec',
// We don't push to sonarcloud since it requires Java 17 since the 15th of November and that would force us
// to make the 14.10.x branch build with Java 17 which is not easy to do. This will autofix itself when the
// next LTS is 15.10.x.
sonar: false
properties: '-Dxwiki.jacoco.itDestFile=`pwd`/target/jacoco-it.exec'
)
}
]
Expand Down

0 comments on commit f8ab461

Please sign in to comment.