CONFLUENCE-413: Add a converter for Jira chart #68
Conversation
| * Convert Confluence jira chart macro. | ||
| * | ||
| * @version $Id$ | ||
| * @since 9.81.0 |
There was a problem hiding this comment.
will need to update the since tags
| String parameterName = toXWikiParameterName(name, confluenceId, parameters, content); | ||
| parameters.put(parameterName, xwikiValue); |
There was a problem hiding this comment.
We should not pass through parameters unless under very specific conditions. We now have automated logs to report unknown parameters, and the pass-through breaks this, and might be problematic for introducing new parameters on the target macros, which could conflict with "passed-though" parameters.
More generally, I think it's better not to iterate over the parameters and handle them with a switch:
- you can just implement
toXWikiParameterNameandtoXWikiParameterValuedirectly to do this - but I prefer not to do this, and implement
toXWikiParameters, and get the parameters you want to convert, and put the result in the resulting parameters map.
Parameters you don't use will be logged., and these logs can help decide what to do, including improving the macro converter. See https://jira.xwiki.org/projects/CONFLUENCE/issues/CONFLUENCE-411. See also xwikisas/application-confluence-migrator-pro#277. You can see how I handled this and how I fixed macro converters to allow this.
|
@Josue-T should this be closed? |
|
Well I don't mind to close it. Maybe at some point we might decide to have a converter for this macro, but in this case we can reopen this and finalize it. |
Jira issue: https://jira.xwiki.org/browse/CONFLUENCE-413
For now it's a draft because: