Add support for color slots (Lottie spec slots/sid)#415
Open
burakimdatt wants to merge 9 commits into
Open
Conversation
…rsions for characters, matcher, material_color_utilities, meta, and test_api packages. Enhance FillContent class to support PathFillType.
…s in design and functionality.
Fixes path fillType assignment timing in both FillContent and GradientFillContent to occur during draw/bounds operations rather than initialization.
- Parse root slots block into composition.colorSlots - Capture property-level sid via KeyframesParser.parseWithSlot - Post-parse walk applies slot colors (order-independent vs layers) - Include FontCharacter shape trees; @internal slotId on AnimatableColorValue - Tests: test/data/slots + test/slots_test.dart Made-with: Cursor
Made-with: Cursor
Made-with: Cursor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #415 +/- ##
==========================================
+ Coverage 83.15% 83.37% +0.22%
==========================================
Files 161 161
Lines 6470 6544 +74
==========================================
+ Hits 5380 5456 +76
+ Misses 1090 1088 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Made-with: Cursor
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Lottie animations that use the spec Slots feature (root
slots+ property-levelsid) render with encodedc.kcolors in Flutter while web players apply the slot override.Solution
slotsintocomposition.colorSlots(static RGB/RGBA only).sidinside animated property objects viaKeyframesParser.parseWithSlot(same location ask,a, etc.).AnimatableColorValuekeyframes when a matching slot exists (order-independent vs root key order).Scope / limitations
p.a: 1) emitcomposition.addWarningand are skipped.setSlotAPI (JSON only).References
Tests
test/slots_test.dart+ synthetic JSON undertest/data/slots/Changelog
## Nextentry added for maintainer version bump.