Skip to content

Commit

Permalink
Dialogs update (ChuckerTeam#309)
Browse files Browse the repository at this point in the history
* Switch from AlertDialog to MaterialAlertDialog
* Update parent style for title style
  • Loading branch information
vbuberen authored Apr 5, 2020
1 parent 41f3c9d commit 53af811
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,14 @@ import android.view.MenuInflater
import android.view.MenuItem
import android.view.View
import android.view.ViewGroup
import androidx.appcompat.app.AlertDialog
import androidx.fragment.app.Fragment
import androidx.lifecycle.Observer
import androidx.lifecycle.ViewModelProvider
import androidx.recyclerview.widget.DividerItemDecoration
import com.chuckerteam.chucker.R
import com.chuckerteam.chucker.databinding.ChuckerFragmentThrowableListBinding
import com.chuckerteam.chucker.internal.ui.MainViewModel
import com.google.android.material.dialog.MaterialAlertDialogBuilder

internal class ThrowableListFragment : Fragment(), ThrowableAdapter.ThrowableClickListListener {

Expand Down Expand Up @@ -75,7 +75,7 @@ internal class ThrowableListFragment : Fragment(), ThrowableAdapter.ThrowableCli
}

private fun askForConfirmation() {
AlertDialog.Builder(requireContext())
MaterialAlertDialogBuilder(requireContext())
.setTitle(R.string.chucker_clear)
.setMessage(R.string.chucker_clear_throwable_confirmation)
.setPositiveButton(R.string.chucker_clear) { _, _ ->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import android.view.MenuInflater
import android.view.MenuItem
import android.view.View
import android.view.ViewGroup
import androidx.appcompat.app.AlertDialog
import androidx.appcompat.widget.SearchView
import androidx.fragment.app.Fragment
import androidx.lifecycle.Observer
Expand All @@ -17,6 +16,7 @@ import androidx.recyclerview.widget.DividerItemDecoration
import com.chuckerteam.chucker.R
import com.chuckerteam.chucker.databinding.ChuckerFragmentTransactionListBinding
import com.chuckerteam.chucker.internal.ui.MainViewModel
import com.google.android.material.dialog.MaterialAlertDialogBuilder

internal class TransactionListFragment :
Fragment(),
Expand Down Expand Up @@ -80,7 +80,7 @@ internal class TransactionListFragment :

override fun onOptionsItemSelected(item: MenuItem): Boolean {
return if (item.itemId == R.id.clear) {
AlertDialog.Builder(requireContext())
MaterialAlertDialogBuilder(requireContext())
.setTitle(R.string.chucker_clear)
.setMessage(R.string.chucker_clear_http_confirmation)
.setPositiveButton(
Expand Down
2 changes: 1 addition & 1 deletion library/src/main/res/layout/chucker_activity_throwable.xml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

<TextView
android:id="@+id/toolbarTitle"
style="@style/Chucker.TextAppearance.TransactionTitle"
style="@style/Chucker.TextAppearance.Title"
android:layout_width="match_parent"
android:layout_height="wrap_content"
tools:text="Title" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:layout_marginEnd="@dimen/chucker_doub_grid"
style="@style/Chucker.TextAppearance.TransactionTitle"
style="@style/Chucker.TextAppearance.Title"
tools:text="Title"/>

</com.google.android.material.appbar.MaterialToolbar>
Expand Down
2 changes: 1 addition & 1 deletion library/src/main/res/values/styles.xml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
<item name="android:textIsSelectable">true</item>
</style>

<style name="Chucker.TextAppearance.TransactionTitle" parent="TextAppearance.AppCompat.Widget.ActionBar.Title">
<style name="Chucker.TextAppearance.Title" parent="TextAppearance.MaterialComponents.Headline6">
<item name="android:textSize">16sp</item>
<item name="android:maxLines">2</item>
</style>
Expand Down

0 comments on commit 53af811

Please sign in to comment.