Skip to content

Commit

Permalink
scsi: qla2xxx: stop timer in shutdown path
Browse files Browse the repository at this point in the history
In shutdown/reboot paths, the timer is not stopped:

  qla2x00_shutdown
  pci_device_shutdown
  device_shutdown
  kernel_restart_prepare
  kernel_restart
  sys_reboot

This causes lockups (on powerpc) when firmware config space access calls
are interrupted by smp_send_stop later in reboot.

Fixes: e30d175 ("[SCSI] qla2xxx: Addition of shutdown callback handler.")
Link: https://lore.kernel.org/r/20191024063804.14538-1-npiggin@gmail.com
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
Acked-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
  • Loading branch information
npiggin authored and martinkpetersen committed Oct 29, 2019
1 parent 0cf9f4e commit d3566ab
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/scsi/qla2xxx/qla_os.c
Original file line number Diff line number Diff line change
Expand Up @@ -3529,6 +3529,10 @@ qla2x00_shutdown(struct pci_dev *pdev)
qla2x00_try_to_stop_firmware(vha);
}

/* Disable timer */
if (vha->timer_active)
qla2x00_stop_timer(vha);

/* Turn adapter off line */
vha->flags.online = 0;

Expand Down

0 comments on commit d3566ab

Please sign in to comment.