fix : AnnotationStatus of Data not changing appropriatly when submitting #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if (ObjectUtil.isNull(sceneId)) {
~
}else if (ObjectUtil.isNotNull(sceneId) && DataStatusEnum.INVALID.equals(status)) {
~
} else if (ObjectUtil.isNotNull(sceneId) && DataStatusEnum.VALID.equals(status)) {
~
}you suggested like this conditional block in #234. when i tested this code, then Once the scene marked as INVALID, there is no way to enter |
fanyinbo
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i made a pull request of #234 .
When you have a time for reviewing it, leave me a comment for it! Thank you!
I tested this code in my local develop server and it works appropriatly as you mentioned!