Pull C0 escape sequences into its own file #461
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #460
This is the plan for #460 but to apply it to CSI and OSC as well. Once we move the relevant code to TS we'll be able to use template literals to make the code very readable. Example:
Would become something like:
Or potentially:
We can also look into having TS inline the constants: microsoft/TypeScript#3922 microsoft/TypeScript#3192
@parisk let me know what you think of the structure.