Update providers, documentation improvements and bug fixes #2562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review for Pull Request: Update providers, documentation improvements and bug fixes
Thank you for contributing to the project! Your efforts in updating the providers, improving documentation, and fixing bugs are greatly appreciated.
Summary of Changes
-
New Providers Added:
AutonomousAICablyAIChatGLMImageLabs
-
Documentation Improvements:
- Added new sections and updated existing ones in
providers-and-models.mdto include new providers and models.
- Added new sections and updated existing ones in
-
Bug Fixes:
- Adjusted the
Airforceprovider to setworkingtoFalse. - Various improvements in the handling of API keys and response parsing across multiple providers.
- Adjusted the
Detailed Feedback
-
New Providers:
- The addition of new providers like
AutonomousAI,CablyAI, andChatGLMenhances the functionality of the project. Ensure that the documentation for these providers is clear and comprehensive.
- The addition of new providers like
-
Documentation:
- The updates to
providers-and-models.mdare well-structured. The inclusion of new models under the respective providers is helpful for users to understand the capabilities of each provider.
- The updates to
-
Code Quality:
- The code changes are clean and follow the existing coding standards. The use of async functions and proper error handling is commendable.
-
Testing:
- Ensure that there are adequate tests for the new providers and any changes made to existing ones. This will help maintain the stability of the project.
-
Deprecation of API Key Check:
- The removal of the API key check in the
Airforceprovider is a significant change. Make sure to document this change clearly, as it may affect users relying on this functionality.
- The removal of the API key check in the
Suggestions
- Consider adding examples in the documentation for how to use the new providers effectively.
- It might be beneficial to include a changelog to track changes made in each version for better transparency.
Overall, this pull request is a great step forward for the project. Thank you once again for your hard work and dedication!
| @@ -8,6 +8,7 @@ This document provides an overview of various AI providers and models, including | |||
| ## Table of Contents | |||
| - [Providers](#providers) | |||
| - [Free](#providers-free) | |||
| - [HuggingSpace](#providers-huggingspace) | |||
There was a problem hiding this comment.
- The entry for
HuggingSpaceshould be consistent with the naming convention used for other providers. Consider using the same case style as other entries.
| @@ -22,10 +23,14 @@ | |||
| |----------|-------------|--------------|---------------|--------|--------|------|------| | |||
| |[api.airforce](https://api.airforce)|`g4f.Provider.Airforce`|`phi-2, openchat-3.5, deepseek-coder, hermes-2-dpo, hermes-2-pro, openhermes-2.5, lfm-40b, german-7b, llama-2-7b, llama-3.1-8b, llama-3.1-70b, neural-7b, zephyr-7b, evil,`|`sdxl, flux-pro, flux, flux-realism, flux-anime, flux-3d, flux-disney, flux-pixel, flux-4o, any-dark, midjourney, dall-e-3`|❌|✔||❌+✔| | |||
| |[amigochat.io](https://amigochat.io/chat/)|`g4f.Provider.AmigoChat`|✔|✔|❌|✔||❌| | |||
| |[blackbox.ai](https://www.blackbox.ai)|`g4f.Provider.Blackbox`|`blackboxai, gpt-4, gpt-4o, gemini-1.5-pro, claude-3.5-sonnet, blackboxai-pro, llama-3.1-8b, llama-3.1-70b, llama-3.3-70b, mixtral-7b, deepseek-chat, dbrx-instruct, qwq-32b, hermes-2-dpo`|`flux`|`blackboxai, gpt-4o, gemini-1.5-pro, gemini-1.5-flash, llama-3.1-8b, llama-3.1-70b, llama-3.1-405b`|✔||❌| | |||
| |[autonomous.ai](https://www.autonomous.ai/anon/)|`g4f.Provider.AutonomousAI`|`llama-3.3-70b, qwen-2.5-coder-32b, hermes-3, llama-3.2-90b, llama-3.3-70b`|✔|❌|✔||❌| | |||
There was a problem hiding this comment.
- The entry for
blackbox.aiappears twice with different details. Ensure that there is no duplication and that the information is accurate.
| @@ -36,37 +41,47 @@ | |||
| |[chat10.free2gpt.xyz](https://chat10.free2gpt.xyz)|`g4f.Provider.Free2GPT`|`mistral-7b`|❌|❌|✔||❌| | |||
| |[freegptsnav.aifree.site](https://freegptsnav.aifree.site)|`g4f.Provider.FreeGpt`|`gemini-1.5-pro`|❌|❌|✔||❌| | |||
| |[app.giz.ai/assistant](https://app.giz.ai/assistant)|`g4f.Provider.GizAI`|`gemini-1.5-flash`|❌|❌|✔||❌| | |||
| |[editor.imagelabs.net](editor.imagelabs.net)|`g4f.Provider.ImageLabs`|❌|✔|❌|✔||❌| | |||
There was a problem hiding this comment.
- The entry for
editor.imagelabs.netis missing a URL format. Ensure that the URL is complete and correctly formatted.
| @@ -36,37 +41,47 @@ | |||
| |[chat10.free2gpt.xyz](https://chat10.free2gpt.xyz)|`g4f.Provider.Free2GPT`|`mistral-7b`|❌|❌|✔||❌| | |||
| |[freegptsnav.aifree.site](https://freegptsnav.aifree.site)|`g4f.Provider.FreeGpt`|`gemini-1.5-pro`|❌|❌|✔||❌| | |||
| |[app.giz.ai/assistant](https://app.giz.ai/assistant)|`g4f.Provider.GizAI`|`gemini-1.5-flash`|❌|❌|✔||❌| | |||
| |[editor.imagelabs.net](editor.imagelabs.net)|`g4f.Provider.ImageLabs`|❌|✔|❌|✔||❌| | |||
| |[huggingface.co/spaces](https://huggingface.co/spaces)|`g4f.Provider.HuggingSpace`|`qwen-2.5-72b, qwen-2.5-72b`|`flux-dev, flux-schnell, sd-3.5`|❌|✔||❌| | |||
There was a problem hiding this comment.
- The entry for
huggingface.co/spaceshas a duplicate model listed. Ensure that each model is unique and not repeated.
| |[liaobots.work](https://liaobots.work)|`g4f.Provider.Liaobots`|`grok-2, gpt-4o-mini, gpt-4o, gpt-4, o1-preview, o1-mini, claude-3-opus, claude-3.5-sonnet, claude-3-sonnet, gemini-1.5-flash, gemini-1.5-pro, gemini-2.0-flash, gemini-2.0-flash-thinking`|❌|❌|✔||❌| | ||
| |[mhystical.cc](https://mhystical.cc)|`g4f.Provider.Mhystical`|`gpt-4`|❌|❌|✔||❌| | ||
| |[labs.perplexity.ai](https://labs.perplexity.ai)|`g4f.Provider.PerplexityLabs`|`sonar-online, sonar-chat, llama-3.3-70b, llama-3.1-8b, llama-3.1-70b, lfm-40b`|❌|❌|✔||❌| | ||
| |[pi.ai/talk](https://pi.ai/talk)|`g4f.Provider.Pi`|`pi`|❌|❌|✔||❌| | ||
| |[pizzagpt.it](https://www.pizzagpt.it)|`g4f.Provider.Pizzagpt`|`gpt-4o-mini`|❌|❌|✔||❌| | ||
| |[pollinations.ai](https://pollinations.ai)|`g4f.Provider.PollinationsAI`|`gpt-4o, mistral-large, mistral-nemo, llama-3.1-70b, gpt-4, qwen-2.5-coder-32b, claude-3.5-sonnet, command-r, evil, p1,turbo, unity, midijourney, rtist`|`flux, flux-realism, flux-cablyai, flux-anime, flux-3d, any-dark, flux-pro, midjourney, dall-e-3`|❌|✔||❌| | ||
| |[pollinations.ai](https://pollinations.ai)|`g4f.Provider.PollinationsAI`|`gpt-4o, mistral-large, mistral-nemo, llama-3.3-70b, gpt-4, qwen-2-72b, qwen-2.5-coder-32b, claude-3.5-sonnet, command-r, deepseek-chat, llama-3.2-3b, evil, p1, turbo, unity, midijourney, rtist`|`flux, flux-realism, flux-cablyai, flux-anime, flux-3d, any-dark, flux-pro, midjourney, dall-e-3`|❌|✔||❌| |
There was a problem hiding this comment.
- The entry for
pollinations.aihas a duplicate model listed. Ensure that each model is unique and not repeated.
| @@ -12,13 +12,14 @@ | |||
| class VoodoohopFlux1Schnell(AsyncGeneratorProvider, ProviderModelMixin): | |||
| url = "https://voodoohop-flux-1-schnell.hf.space" | |||
| api_endpoint = "https://voodoohop-flux-1-schnell.hf.space/call/infer" | |||
|
|
|||
| working = True | |||
|
|
|||
There was a problem hiding this comment.
The working attribute is added but not explained in the code's context. Verify if it is being utilized effectively elsewhere in the class or if additional handling is required.
| working = True | ||
|
|
||
| default_model = "flux-schnell" | ||
| default_model = "voodoohop-flux-1-schnell" |
There was a problem hiding this comment.
The default_model value has been changed to voodoohop-flux-1-schnell. Ensure that this change is intentional and consistent with any external dependencies or references that expect the previous value, flux-schnell.
| models = [*image_models] | ||
| model_aliases = {"flux-schnell-voodoohop": default_model} | ||
| models = image_models | ||
| model_aliases = {"flux-schnell": default_model} |
There was a problem hiding this comment.
The key flux-schnell in model_aliases has been updated to replace flux-schnell-voodoohop. Validate whether this change aligns with the expected behavior of the alias mapping and verify downstream impacts, if any.
| @@ -72,4 +73,4 @@ | |||
| json_data = json.loads(data) | |||
| image_url = json_data[0]['url'] | |||
| yield ImageResponse(images=[image_url], alt=prompt) | |||
There was a problem hiding this comment.
The return statement has been removed. Ensure that its removal does not impact the function's behavior, especially if the return was crucial for terminating execution or compatibility with consumers of this output.
| @@ -46,11 +46,10 @@ class HuggingChat(AbstractProvider, ProviderModelMixin): | |||
| 'NousResearch/Hermes-3-Llama-3.1-8B', | |||
| 'mistralai/Mistral-Nemo-Instruct-2407', | |||
| 'microsoft/Phi-3.5-mini-instruct', | |||
| *image_models | |||
| ] | |||
| ] + image_models | |||
| model_aliases = { | |||
| ### Chat ### | |||
There was a problem hiding this comment.
Ensure the alias 'qwen-2.5-72b' for 'Qwen/Qwen2.5-72B-Instruct' is either retained or necessary documentation updates reflect this change in the model alias mapping.
Pull Request ReviewThank you for your contribution to the project, None! Below is my review of your pull request titled "Update providers, documentation improvements and bug fixes". Summary of ChangesThis pull request introduces the following significant updates:
Suggestions & Feedback1. Documentation
2. Code Quality
3. Testing
Review OutcomeOverall, the contribution:
However, a few minor documentation updates and code refactorings can make this PR even better. Thank you again for making these significant updates to the project! Let me know if you have any questions or need clarification on any of the issues mentioned. Review ApprovalI recommend APPROVING the pull request after incorporating the above suggestions. With appreciation, |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.