-
-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add login url to HuggingFace in Web UI #2555
Conversation
Add some HuggingSpace providers Add icon to home.html Remove duplicate lines from web search results Fix object async_generator can't be used in 'await' Fix for continue message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review for Pull Request by H Lohaus
Title: Add login url to HuggingFace in Web UI
Summary
This pull request effectively adds some HuggingFace providers and enhances the web UI by updating home.html, removing duplicate lines, and addressing issues with async generators. The changes improve the overall functionality and user experience of the application.
Changes Overview:
- Added HuggingFace providers: New provider classes
Qwen_QVQ_72B
andStableDiffusion35Large
have been added to the HuggingFace section. - Icon additions in home.html: Relevant icons were included to enhance the UI.
- Code Cleanup: Duplicate lines were removed from the web search results for better code quality.
- Bug Fixes:
- Fixed the usage of
async_generator
increate_async_generator
, preventing runtime errors. - Improved handling of the continue message feature.
- Fixed the usage of
Code Quality
The code follows existing project conventions and structures properly. The addition of new providers and the fixes made show attention to detail and a good understanding of the project requirements.
Suggestions
Consider adding more unit tests for the newly introduced providers to ensure that all functionalities are verified during further modifications.
Conclusion
Thank you, H Lohaus, for your contribution to the project. Your efforts in improving the HuggingFace integration and overall code quality are much appreciated!
Approvals
- Code changes look good to me
- Requesting one more review before merging
@@ -5,6 +5,7 @@ | |||
|
|||
class Jmuz(OpenaiAPI): | |||
label = "Jmuz" | |||
login_url = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The login_url
should be initialized with a valid URL instead of None
.
Review for Pull Request: Add login url to HuggingFace in Web UISummaryThank you, H Lohaus, for your contribution to the project! This pull request adds a login URL for HuggingFace in the Web UI, introduces new HuggingSpace providers, updates the home page with icons, removes duplicate lines from web search results, and fixes issues related to async generators and continue messages. Changes
Code Quality
Suggestions
Overall, this is a solid contribution that enhances the functionality and usability of the project. Thank you once again for your hard work and dedication to improving the project! |
Review for Pull Request: Add login url to HuggingFace in Web UISummaryThank you, H Lohaus, for your contribution to the project! This pull request adds a login URL for HuggingFace in the Web UI, introduces new HuggingSpace providers, updates the home page with icons, removes duplicate lines from web search results, and fixes issues related to async generators and continue messages. Changes
Code Quality
Suggestions
Overall, this is a solid contribution that enhances the project significantly. I appreciate your efforts in improving the functionality and user experience of the application. ApprovalI approve this pull request. Thank you for your hard work and dedication to the project! |
Add some HuggingSpace providers
Add icon to home.html
Remove duplicate lines from web search results
Fix object async_generator can't be used in 'await'
Fix for continue message