Remove caret escaping from cmd commands #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in #17 looks to have fixed the issues with
pwshandbash, as well as some minor issues withcmd.exe, but when a script likedotnet --version && dotnet --infois run incmd.exeonly the left portion executes. The escaped^&^&is acting as a terminator.Based on what I've read, and the code in the dotnet sdk, escaping everything is the right way to do this. But based on real world testing the command portion doesn't need escaping, and doing so breaks some things. The additional arguments passed with the double dash still need this level of escaping but I'm sure another edge case will come up after merging this.