Set LogFilePrefix for test result files #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xt0rted
force-pushed
the
xt0rted-patch-1
branch
2 times, most recently
from
9d6929f to
cd94b4b
Compare
xt0rted
force-pushed
the
xt0rted-patch-1
branch
2 times, most recently
from
a08e430 to
87ee210
Compare
xt0rted
commented
Apr 23, 2022
| - run: | | ||
| if [ "${{ matrix.shell }}" == "default" ]; then | ||
| dotnet r test --verbose | ||
| dotnet r test --verbose -- --logger "trx;LogFilePrefix=${{ matrix.os }}-integration-tests" |
Owner
Author
There was a problem hiding this comment.
This needs to be carried over to the build job after merging, along with updating to the latest preview build.
xt0rted
commented
Apr 23, 2022
Comment on lines
+149
to
+154
| - name: Upload test results | ||
| uses: actions/upload-artifact@v3.0.0 | ||
| if: always() | ||
| with: | ||
| name: integration-test-results | ||
| path: ./.coverage/*.trx |
Owner
Author
There was a problem hiding this comment.
This won't take effect until it's merged to main.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the test file prefix results in consistent naming of test files because they then include the runtime identifier which makes it a little easier to review in the post run test overview.
While testing this it was found that parameters without spaces sometimes need to be quoted as well, so there's also a fix that removed the conditional quote check so everything gets quoted now.