-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: Improper namespacing of inline deps causes collisions #22
Comments
@frenchy64 Thanks for reporting this! Could you paste any stacktrace that you're seeing, just so this issue is discoverable for people with similar problems? This should - in theory - be fixed by enabling Java class repackaging in mranderson. I'll just need to check if there was a reason I originally disabled it. |
Okay, short immediate update: The repackaging misses some of the class files, namely it prefixes all the |
And another follow-up: That issue seems to be fixed in |
Aaaaand... one step back. Inlining potemkin/riddley is currently not possible because of benedekfazekas/mranderson#52. So, I think I'm going for the nuclear option of taking the one (!) function from |
This also removes the need for isolation. Fixes #22.
It was discovered by lein-collisions in a project that depends on both pandect and clj-tuple.
|
There are several dependencies that are inlined without a namespace prefix in 1.0.1 (after upgrading from 0.6.1). See all the files not starting with
pandect
in the file list of the 1.0.1 jar below:Seems to be caused by 42f0302
The text was updated successfully, but these errors were encountered: