fix bang handling in AST printer

xrstf · Dec 28, 2023 · c7e8129 · c7e8129
1 parent e61d735
commit c7e8129
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/pkg/lang/parser/test/parser_test.go b/pkg/lang/parser/test/parser_test.go
@@ -48,7 +48,7 @@ func TestParseProgram(t *testing.T) {
 		},
 		{
 			input:    `(func+ -foo bar!)`,
-			expected: `(tuple (identifier func+) (identifier -foo) (identifier bar!))`,
+			expected: `(tuple (identifier func+) (identifier -foo) (identifier bar (bang)))`,
 		},
 		{
 			input:    `(1)`,

diff --git a/pkg/printer/printer_ast.go b/pkg/printer/printer_ast.go
@@ -41,16 +41,19 @@ func (p *astPrinter) String(str string) error {
 }
 
 func (p *astPrinter) Identifier(ident *ast.Identifier) error {
-	// TODO: Include Bang modifier
-	return p.write(fmt.Sprintf("(identifier %s)", *ident))
+	var bang string
+	if ident.Bang {
+		bang = " (bang)"
+	}
+
+	return p.write(fmt.Sprintf("(identifier %s%s)", ident.Name, bang))
 }
 
 func (p *astPrinter) Vector(vec []any) error {
 	return p.printVector(vec, nil)
 }
 
 func (p *astPrinter) VectorNode(vec *ast.VectorNode) error {
-	// TODO: Use copy()?
 	data := make([]any, len(vec.Expressions))
 	for i := range vec.Expressions {
 		data[i] = vec.Expressions[i]

diff --git a/pkg/printer/printer_rudi.go b/pkg/printer/printer_rudi.go
@@ -55,7 +55,6 @@ func (p *rudiPrinter) Vector(vec []any) error {
 }
 
 func (p *rudiPrinter) VectorNode(vec *ast.VectorNode) error {
-	// TODO: Use copy()?
 	data := make([]any, len(vec.Expressions))
 	for i := range vec.Expressions {
 		data[i] = vec.Expressions[i]