Merge pull request Medium#265 from Medium/nick-nodejs

Turn off strictssl on node v0.10.34. Fixes Medium#262
xperious · Dec 19, 2014 · e4bb0d6 · e4bb0d6
2 parents bf1ec7a + a54f760
commit e4bb0d6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/install.js b/install.js
@@ -205,12 +205,19 @@ function findSuitableTempDirectory(npmConf) {
 
 
 function getRequestOptions(conf) {
+  var strictSSL = conf.get('strict-ssl')
+  if (process.version == 'v0.10.34') {
+    console.log('Node v0.10.34 detected, turning off strict ssl due to https://github.com/joyent/node/issues/8894')
+    strictSSL = false
+  }
+
+
   var options = {
     uri: downloadUrl,
     encoding: null, // Get response as a buffer
     followRedirect: true, // The default download path redirects to a CDN URL.
     headers: {},
-    strictSSL: conf.get('strict-ssl')
+    strictSSL: strictSSL
   }
 
   var proxyUrl = conf.get('https-proxy') || conf.get('http-proxy') || conf.get('proxy')

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "phantomjs",
-  "version": "1.9.12",
+  "version": "1.9.13",
   "keywords": [
     "phantomjs",
     "headless",