PHP 8 compatibility

[thekid]

Looks good after PHP8 was branched off a week ago.

$ XP_RT=master xp -v
XP 10.0.0-dev { PHP/8.0.0-dev & Zend/4.0.0-dev } @ Windows NT SLATE 10.0 build 17134...
Copyright (c) 2001-2019 the XP group
FileSystemCL<./src/main/php>
FileSystemCL<./src/test/php>
FileSystemCL<./src/main/resources>
FileSystemCL<./src/test/resources>
ArchiveCL<./test.xar>
FileSystemCL<.>

$ XP_RT=master xp test src/test/config/unittest/core.ini
# ...

♥: 2198/2223 run (25 skipped), 2198 succeeded, 0 failed
Memory used: 10967.42 kB (11992.66 kB peak)
Time taken: 4.153 seconds

[thekid]

Deprecation ideas for PHP 8 - https://externals.io/message/103779

[thekid]

Nightly PHP is PHP 8.0 on Travis CI, see e.g. https://travis-ci.org/xp-framework/core/jobs/503562507

[thekid]

PHP 7.4 can currently be referenced via 7.4snapshot, see here - so added this to test matrix: https://travis-ci.org/xp-framework/core/jobs/503566028

[thekid]

✅ PHP 8.0 tests are green - https://travis-ci.org/xp-framework/core/builds/503566023 🎉

[thekid]

⚠️ https://travis-ci.org/xp-framework/core/builds/544340243 (PHP 8.0) failed with:

Uncaught exception: Exception lang.IndexOutOfBoundsException (Undefined index: expect)
  at <main>::__error(8, (0x17)'...', (0x50)'...', 195) [line 195 of Routine.class.php]
  at lang.reflect.Routine::hasAnnotation((0x6)'...', (0x5)'....') [line 155 of TestRun.class.php] 

This is due to changes in how array_key_exists handles non-array parameters - addressed in c105caf

[thekid]

⚠️ https://travis-ci.org/xp-framework/core/jobs/544376939 (PHP 8.0) has been generating new warnings in need of addressing:

• date_date_set() expects parameter 2 to be int, string given
• lstat(): Lstat failed for /home/travis/build/xp-framework/core/@does-not-exist@" in ::lstat()
• stat(): stat failed for iostrr://..." in ::stat()
• fread() expects parameter 1 to be resource, null given
• iconv_strlen(): Detected an incomplete multibyte character in input string

[thekid]

✅ All PHP versions are back to green now - https://travis-ci.org/xp-framework/core/builds/544428148

[thekid]

New bug in PHP 7.4 and PHP 8.0 -> #221

[thekid]

All PHP versions still green - https://travis-ci.org/xp-framework/core/builds/591065089

[thekid]

PHP 8.0 related fix for this released: https://github.com/xp-framework/core/releases/tag/v10.0.1

[thekid]

With support for PHP 7.4 property types and PHP 8 union types, PHP 8 branch is green -> https://travis-ci.org/github/xp-framework/core/jobs/671282713

[thekid]

Some new deprecations which need to be addressed, see php/php-src#5209:

• Method ReflectionParameter::isArray() is deprecated
• Method ReflectionParameter::isCallable() is deprecated
• Method ReflectionParameter::getClass() is deprecated