Fix accessing params from a request with content-type, but without co…

…ntent

ChangeLog.md

@@ -3,6 +3,10 @@ Web change log
 
 ## ?.?.? / ????-??-??
 
+* Fixed accessing params from a request with content-type, but without
+  content; following the *be liberal in what you accept* paradigm.
+  (@thekid)
+
 ## 4.4.1 / 2024-07-07
 
 * Fixed request dispatching inside development webserver - @thekid

src/main/php/web/Request.class.php

@@ -125,8 +125,8 @@ private function parse($peek= true) {
     // Merge parameters from URL and urlencoded payload.
     $query= $this->uri->query(false) ?? '';
     $type= Headers::parameterized()->parse($this->header('Content-Type', ''));
-    if ('application/x-www-form-urlencoded' === $type->value()) {
-      $data= Streams::readAll($this->input->incoming());
+    if ('application/x-www-form-urlencoded' === $type->value() && $stream= $this->input->incoming()) {
+      $data= Streams::readAll($stream);
       $this->stream= new MemoryInputStream($data);
       $query.= '&'.$data;
     }

src/test/php/web/unittest/RequestTest.class.php

@@ -314,4 +314,13 @@ public function hash_code() {
     $req= new Request(new TestInput('GET', '/', ['Host' => 'localhost', 'Connection' => 'close']));
     Assert::equals(spl_object_hash($req), $req->hashCode());
   }
+
+  #[Test]
+  public function form_encoded_without_payload() {
+    $headers= ['Content-Type' => 'application/x-www-form-urlencoded'];
+    Assert::equals(
+      ['source' => 'query'],
+      (new Request(new TestInput('DELETE', '/?source=query', $headers)))->params()
+    );
+  }
 }