Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add equals() methods for wrapper classes #44

Merged
merged 2 commits into from
Dec 30, 2023
Merged

Add equals() methods for wrapper classes #44

merged 2 commits into from
Dec 30, 2023

Conversation

thekid
Copy link
Member

@thekid thekid commented Dec 30, 2023

Example

The following code becomes clearer:

  $user= ...
  foreach ($comments as $comment) {
-   if (0 === $comment['user']['id']->compareTo($user->id()) {
+   if ($comment['user']['id']->equals($user->id()) { 
      // Comment was made by user
    }
  }

Wrapper classes

These classes now have an equals() method alongside compareTo():

  • ObjectId
  • Int64
  • Decimal128
  • Code

The MinKey, MaxKey and Timestamp classes do not have this method.

@thekid thekid added the enhancement New feature or request label Dec 30, 2023
@thekid thekid merged commit 2aad76d into master Dec 30, 2023
20 checks passed
@thekid thekid deleted the feature/equals branch December 30, 2023 13:28
@thekid
Copy link
Member Author

thekid commented Dec 30, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant