Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add single step mode #23

Closed
wants to merge 7 commits into from
Closed

Add single step mode #23

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fecbbc9
chore(gitignore): ignore bundle-generated directories
thislooksfun Jun 15, 2020
107e998
test: add tests for 'single_step' option
thislooksfun Jun 15, 2020
f54565e
feat: add 'single_step' mode
thislooksfun Jun 16, 2020
f996b32
fix: fix typo
thislooksfun Jun 16, 2020
3a5b31c
fix: fix single_step not working for minor releases
thislooksfun Jun 17, 2020
bc6f4c2
test: fix faulty test
thislooksfun Jun 17, 2020
c4c0905
refactor: split next version finding into own method
thislooksfun Jun 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor: split next version finding into own method
  • Loading branch information
@thislooksfun
thislooksfun committed Jun 17, 2020
commit c4c09058dd2eb5df564e8d2513c04ec7fe6a8a62
40 changes: 28 additions & 12 deletions lib/fastlane/plugin/semantic_release/actions/analyze_commits.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,32 @@ def self.is_releasable(params)
UI.message("Found a tag #{tag_name} associated with version #{version}")
end

next_version = find_next_version(
version: version,
hash: hash,
releases: params[:releases],
ignore_scopes: params[:ignore_scopes],
single_step: params[:single_step],
debug: params[:debug]
)

is_next_version_releasable = Helper::SemanticReleaseHelper.semver_gt(next_version, version)

Actions.lane_context[SharedValues::RELEASE_ANALYZED] = true
Actions.lane_context[SharedValues::RELEASE_IS_NEXT_VERSION_HIGHER] = is_next_version_releasable
# Last release analysis
Actions.lane_context[SharedValues::RELEASE_LAST_TAG_HASH] = hash
Actions.lane_context[SharedValues::RELEASE_LAST_VERSION] = version

success_message = "Next version (#{next_version}) is higher than last version (#{version}). This version should be released."
UI.success(success_message) if is_next_version_releasable

is_next_version_releasable
end

def self.find_next_version(params)
version = params[:version]

# converts last version string to the int numbers
next_major = (version.split('.')[0] || 0).to_i
next_minor = (version.split('.')[1] || 0).to_i
Expand All @@ -88,7 +114,7 @@ def self.is_releasable(params)

# Get commits log between last version and head
splitted = get_commits_from_hash(
hash: hash,
hash: params[:hash],
debug: params[:debug]
)

Expand Down Expand Up @@ -141,23 +167,13 @@ def self.is_releasable(params)

next_version = "#{next_major}.#{next_minor}.#{next_patch}"

is_next_version_releasable = Helper::SemanticReleaseHelper.semver_gt(next_version, version)

Actions.lane_context[SharedValues::RELEASE_ANALYZED] = true
Actions.lane_context[SharedValues::RELEASE_IS_NEXT_VERSION_HIGHER] = is_next_version_releasable
# Last release analysis
Actions.lane_context[SharedValues::RELEASE_LAST_TAG_HASH] = hash
Actions.lane_context[SharedValues::RELEASE_LAST_VERSION] = version
# Next release analysis
Actions.lane_context[SharedValues::RELEASE_NEXT_MAJOR_VERSION] = next_major
Actions.lane_context[SharedValues::RELEASE_NEXT_MINOR_VERSION] = next_minor
Actions.lane_context[SharedValues::RELEASE_NEXT_PATCH_VERSION] = next_patch
Actions.lane_context[SharedValues::RELEASE_NEXT_VERSION] = next_version

success_message = "Next version (#{next_version}) is higher than last version (#{version}). This version should be released."
UI.success(success_message) if is_next_version_releasable

is_next_version_releasable
return next_version
end

def self.is_codepush_friendly(params)
Expand Down