Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow exclusion of scopes from analyze_commits #16

Merged
merged 1 commit into from
Dec 10, 2019
Merged

feat: allow exclusion of scopes from analyze_commits #16

merged 1 commit into from
Dec 10, 2019

Conversation

hanno-jonlay
Copy link
Contributor

Discussed over in #7

I thought I'd put out the PR here, because otherwise it'll just get abandoned - it should work as expected - when you call analyze_commits(ignore_scopes: ['android','windows']), it will ignore any commits which have those scopes within them.

What I'm not happy about, is that even if the commits are ignored by the analyze_commits action, they would still be included in the conventional_changelog.

Ideally, excluding a commit like this would create something like a Fastlane::Actions::SharedValues::RELEASE_COMMITS array, which would not include the ignored scopes, and the conventional_changelog action would automatically read from that array.

But that's more of a change to the way this plugin works, so would have to be handled separately 😄

I'm not going to have any time to touch this for the next few months, sadly. So if anybody wants to build upon it, etc, they're more than welcome to.

@aecorredor
Copy link

aecorredor commented Dec 6, 2019

@jonlay I'm gonna try to work on this:

Ideally, excluding a commit like this would create something like a Fastlane::Actions::SharedValues::RELEASE_COMMITS array, which would not include the ignored scopes, and the conventional_changelog action would automatically read from that array.

on another PR and see if I can get it to work. I think we can still get this in for now though. What do you think @xotahal?

@hanno-jonlay
Copy link
Contributor Author

Awesome! And sounds great - if you can pull it off, what would be great is that conventional_changelog should not need to do anything like this, as it's doing right now:

commits = get_commits_from_hash(hash: last_tag_hash)
parsed = parse_commits(commits)

Would definitely keep things DRY and more versatile, as a properly structured SharedValues::RELEASE_COMMITS would be much easier to iterate through.

@xotahal xotahal merged commit 498063b into xotahal:master Dec 10, 2019
aminerol added a commit to aminerol/fastlane-plugin-semantic_release that referenced this pull request Dec 2, 2020
feat: allow exclusion of scopes from analyze_commits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants