Skip to content

FEAT: Support fury #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 12, 2023
Merged

FEAT: Support fury #76

merged 7 commits into from
Sep 12, 2023

Conversation

codingl2k1
Copy link
Contributor

What do these changes do?

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v0.2.0 milestone Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023

Codecov Report

Merging #76 (257f471) into main (2683f2e) will increase coverage by 0.10%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   89.00%   89.10%   +0.10%     
==========================================
  Files          47       48       +1     
  Lines        3991     4012      +21     
  Branches      760      764       +4     
==========================================
+ Hits         3552     3575      +23     
+ Misses        356      352       -4     
- Partials       83       85       +2     
Flag Coverage Δ
unittests 88.93% <95.23%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
python/xoscar/serialization/pyfury.py 95.23% <95.23%> (ø)

... and 2 files with indirect coverage changes

@codingl2k1 codingl2k1 marked this pull request as ready for review September 12, 2023 06:07
Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aresnow1 aresnow1 merged commit 17881dd into xorbitsai:main Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants