Skip to content

CHORE: Remove win32 support #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

ChengjieLi28
Copy link
Contributor

@ChengjieLi28 ChengjieLi28 commented Sep 4, 2023

What do these changes do?

Test passed: https://github.com/ChengjieLi28/xoscar/actions/runs/6068932033

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v0.1.1 milestone Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Merging #73 (312727d) into main (c192564) will decrease coverage by 4.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   88.84%   84.39%   -4.46%     
==========================================
  Files          47       47              
  Lines        3928     3928              
  Branches      757      757              
==========================================
- Hits         3490     3315     -175     
- Misses        353      541     +188     
+ Partials       85       72      -13     
Flag Coverage Δ
unittests 84.19% <ø> (-4.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aresnow1 aresnow1 merged commit 5838440 into xorbitsai:main Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants