Skip to content

BUG: Fix arrow serialization #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

codingl2k1
Copy link
Contributor

What do these changes do?

Related issue number

Fixes xorbitsai/xorbits#638

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the bug Something isn't working label Aug 14, 2023
@XprobeBot XprobeBot added this to the v0.1.0 milestone Aug 14, 2023
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #64 (c20d210) into main (125bb06) will decrease coverage by 0.38%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   94.28%   93.91%   -0.38%     
==========================================
  Files          47       46       -1     
  Lines        3675     3647      -28     
  Branches      709      705       -4     
==========================================
- Hits         3465     3425      -40     
- Misses        137      146       +9     
- Partials       73       76       +3     
Flag Coverage Δ
unittests 93.77% <100.00%> (-0.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
python/xoscar/serialization/__init__.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit ca36b9f into xorbitsai:main Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: ValueError: memoryview assignment: lvalue and rvalue have different structures
4 participants