BUG: fix xoscar installed by pypi not contains xoscar_pygloo.so #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #62 +/- ##
==========================================
- Coverage 94.28% 93.79% -0.49%
==========================================
Files 47 47
Lines 3675 3675
Branches 709 709
==========================================
- Hits 3465 3447 -18
- Misses 137 152 +15
- Partials 73 76 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
ChengjieLi28
previously approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
build CI passed at this link https://github.com/YibinLiu666/xoscar/actions/runs/5817934992
Related issue number
Fixes #61
Check code requirements