Skip to content

ENH: separate ray #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Conversation

qianduoduo0904
Copy link
Contributor

What do these changes do?

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the enhancement New feature or request label Mar 8, 2023
@XprobeBot XprobeBot added this to the v0.0.1 milestone Mar 8, 2023
@qianduoduo0904 qianduoduo0904 marked this pull request as ready for review March 8, 2023 08:04
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #6 (e956baa) into main (4aa2003) will decrease coverage by 1.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #6      +/-   ##
==========================================
- Coverage   92.20%   91.02%   -1.18%     
==========================================
  Files          49       41       -8     
  Lines        3888     3188     -700     
  Branches      750      638     -112     
==========================================
- Hits         3585     2902     -683     
+ Misses        219      213       -6     
+ Partials       84       73      -11     
Flag Coverage Δ
unittests 90.87% <100.00%> (-1.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/xoscar/metrics/api.py 77.39% <ø> (-15.81%) ⬇️
python/xoscar/backends/communication/base.py 100.00% <100.00%> (ø)
python/xoscar/backends/communication/dummy.py 97.67% <100.00%> (ø)
python/xoscar/backends/communication/socket.py 97.65% <100.00%> (ø)
python/xoscar/backends/communication/ucx.py 66.39% <100.00%> (ø)
python/xoscar/backends/pool.py 95.51% <100.00%> (-0.01%) ⬇️
python/xoscar/debug.py 92.70% <100.00%> (+0.07%) ⬆️
python/xoscar/serialization/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aresnow1 aresnow1 merged commit 3a77590 into xorbitsai:main Mar 8, 2023
@qianduoduo0904 qianduoduo0904 deleted the enh/seperate-ray branch March 8, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants