Skip to content

ENH: Environment variable to set the Xoscar temp directory. #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 5, 2023

Conversation

MarcelHoh
Copy link
Contributor

Following the discussion on my question on the slack channel, this PR adds the ability to set an environment variable for the xoscar temp directory. I've just called it XOSCAR_DIR for now. If the variable is not set the old behaviour of using the home directory is maintened.

@XprobeBot XprobeBot added this to the v0.0.9 milestone Aug 5, 2023
@MarcelHoh MarcelHoh changed the title Xoscar env variable Environment variable to set the Xoscar temp directory. Aug 5, 2023
@qinxuye qinxuye changed the title Environment variable to set the Xoscar temp directory. ENH: Environment variable to set the Xoscar temp directory. Aug 5, 2023
@XprobeBot XprobeBot added the enhancement New feature or request label Aug 5, 2023
@qinxuye
Copy link
Contributor

qinxuye commented Aug 5, 2023

Seems there are some format issue, we use black to format codes, you can run black xoscar.

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Merging #58 (c7754a4) into main (a868b1c) will increase coverage by 0.32%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head c7754a4 differs from pull request most recent head 56a37df. Consider uploading reports for the commit 56a37df to get more accurate results

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   93.46%   93.78%   +0.32%     
==========================================
  Files          47       47              
  Lines        3671     3671              
  Branches      708      708              
==========================================
+ Hits         3431     3443      +12     
+ Misses        160      152       -8     
+ Partials       80       76       -4     
Flag Coverage Δ
unittests 93.65% <100.00%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
python/xoscar/constants.py 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Copy link
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 6a26005 into xorbitsai:main Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants