Skip to content

FEAT: Add / remove a sub pool #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Sep 8, 2023

Conversation

ChengjieLi28
Copy link
Contributor

@ChengjieLi28 ChengjieLi28 commented Aug 1, 2023

What do these changes do?

Related issue number

Fixes #53

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v0.0.9 milestone Aug 1, 2023
@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #54 (44e98af) into main (b153a14) will increase coverage by 0.25%.
The diff coverage is 96.87%.

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   88.82%   89.07%   +0.25%     
==========================================
  Files          47       47              
  Lines        3928     3991      +63     
  Branches      757      760       +3     
==========================================
+ Hits         3489     3555      +66     
  Misses        352      352              
+ Partials       87       84       -3     
Flag Coverage Δ
unittests 88.90% <96.87%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
python/xoscar/backends/communication/socket.py 97.20% <ø> (+0.46%) ⬆️
python/xoscar/backends/indigen/pool.py 94.57% <95.23%> (+1.23%) ⬆️
python/xoscar/backends/config.py 87.01% <100.00%> (+3.45%) ⬆️
python/xoscar/backends/test/pool.py 100.00% <100.00%> (+1.53%) ⬆️

... and 2 files with indirect coverage changes

📢 Have feedback on the report? Share it here.

@ChengjieLi28 ChengjieLi28 marked this pull request as ready for review August 2, 2023 04:43
@ChengjieLi28 ChengjieLi28 force-pushed the feat/add_new_sub_pool branch from 3d8f96f to 6cdb1a7 Compare August 2, 2023 14:11
@XprobeBot XprobeBot modified the milestones: v0.0.9, Temp Aug 5, 2023
@XprobeBot XprobeBot modified the milestones: v0.1.0, v0.1.1 Aug 14, 2023
Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aresnow1 aresnow1 merged commit 2683f2e into xorbitsai:main Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEAT: add and remove subpool
3 participants