Skip to content

ENH: try to increase coverage #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2023
Merged

Conversation

qianduoduo0904
Copy link
Contributor

What do these changes do?

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the testing Testing functions or related to the test suite label Mar 7, 2023
@XprobeBot XprobeBot added this to the v1.0.0 milestone Mar 7, 2023
@qianduoduo0904 qianduoduo0904 marked this pull request as ready for review March 7, 2023 06:08
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #5 (4c8c295) into main (50f9b65) will increase coverage by 12.44%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main       #5       +/-   ##
===========================================
+ Coverage   79.76%   92.20%   +12.44%     
===========================================
  Files          54       49        -5     
  Lines        4532     3888      -644     
  Branches      849      750       -99     
===========================================
- Hits         3615     3585       -30     
+ Misses        840      219      -621     
- Partials       77       84        +7     
Flag Coverage Δ
unittests 92.05% <ø> (+12.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/xoscar/aio/__init__.py 100.00% <ø> (ø)
python/xoscar/aio/lru.py
python/xoscar/nvutils.py
python/xoscar/entrypoints.py
python/xoscar/backends/communication/ucx.py 66.39% <0.00%> (+30.29%) ⬆️
python/xoscar/backends/communication/utils.py 100.00% <0.00%> (+46.15%) ⬆️
python/xoscar/serialization/cuda.py 84.37% <0.00%> (+57.81%) ⬆️
python/xoscar/serialization/arrow.py 100.00% <0.00%> (+64.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@qianduoduo0904 qianduoduo0904 force-pushed the enh/cov branch 2 times, most recently from 540e3eb to 93442a1 Compare March 7, 2023 09:52
@qianduoduo0904 qianduoduo0904 changed the title TST: try to increase coverage ENH: try to increase coverage Mar 7, 2023
@XprobeBot XprobeBot added enhancement New feature or request and removed testing Testing functions or related to the test suite labels Mar 7, 2023
Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aresnow1 aresnow1 merged commit 4aa2003 into xorbitsai:main Mar 8, 2023
@qianduoduo0904 qianduoduo0904 deleted the enh/cov branch March 8, 2023 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants