Skip to content

BUG: cannot import file_object_ref from xoscar directly #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

ChengjieLi28
Copy link
Contributor

What do these changes do?

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the bug Something isn't working label Jul 6, 2023
@XprobeBot XprobeBot added this to the v0.0.6 milestone Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #39 (8583264) into main (7d2f12f) will decrease coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   94.08%   93.82%   -0.27%     
==========================================
  Files          43       43              
  Lines        3399     3399              
  Branches      675      675              
==========================================
- Hits         3198     3189       -9     
- Misses        132      139       +7     
- Partials       69       71       +2     
Flag Coverage Δ
unittests 93.67% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/xoscar/backends/indigen/pool.py 93.33% <ø> (ø)
python/xoscar/backends/pool.py 95.94% <ø> (ø)

... and 6 files with indirect coverage changes

@mergify mergify bot merged commit 7531e22 into xorbitsai:main Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants