Skip to content

BUG: Modify match words for catching error message #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2023

Conversation

aresnow1
Copy link
Contributor

@aresnow1 aresnow1 commented Jul 5, 2023

What do these changes do?

For some versions of Python, it raises RuntimeError: cannot schedule new futures after shutdown, use "cannot schedule new futures " to match error message.

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the bug Something isn't working label Jul 5, 2023
@XprobeBot XprobeBot added this to the v0.0.6 milestone Jul 5, 2023
@codecov
Copy link

codecov bot commented Jul 5, 2023

Codecov Report

Merging #37 (71fba23) into main (1ea9836) will increase coverage by 1.52%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   92.08%   93.61%   +1.52%     
==========================================
  Files          43       43              
  Lines        3399     3399              
  Branches      675      675              
==========================================
+ Hits         3130     3182      +52     
+ Misses        197      145      -52     
  Partials       72       72              
Flag Coverage Δ
unittests 93.46% <ø> (+1.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/xoscar/backends/indigen/pool.py 93.33% <ø> (ø)
python/xoscar/backends/pool.py 95.94% <ø> (ø)

... and 6 files with indirect coverage changes

Copy link
Contributor

@codingl2k1 codingl2k1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants