Skip to content

CLN: Remove n_io_process #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2023
Merged

Conversation

aresnow1
Copy link
Contributor

@aresnow1 aresnow1 commented Apr 23, 2023

What do these changes do?

The code about n_io_process will be moved into Xorbits in xorbitsai/xorbits#401, remove code in Xoscar.

Related issue number

Fixes #20

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added this to the v0.0.6 milestone Apr 23, 2023
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Merging #21 (173189e) into main (6c56257) will increase coverage by 0.32%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   90.98%   91.30%   +0.32%     
==========================================
  Files          42       42              
  Lines        3205     3187      -18     
  Branches      641      638       -3     
==========================================
- Hits         2916     2910       -6     
+ Misses        215      204      -11     
+ Partials       74       73       -1     
Flag Coverage Δ
unittests 91.15% <100.00%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/xoscar/backends/indigen/backend.py 100.00% <ø> (+30.76%) ⬆️
python/xoscar/backends/test/backend.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@qianduoduo0904 qianduoduo0904 changed the title Remove n_io_process CLN: Remove n_io_process Apr 23, 2023
@XprobeBot XprobeBot added the enhancement New feature or request label Apr 23, 2023
Copy link
Contributor

@qianduoduo0904 qianduoduo0904 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify mergify bot merged commit d4ace47 into xorbitsai:main Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CLN: Remove n_io_process logic
4 participants