Skip to content

ENH: use tempfile.gettempdir() for temp dir #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

qianduoduo0904
Copy link
Contributor

What do these changes do?

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the enhancement New feature or request label Apr 7, 2023
@XprobeBot XprobeBot added this to the v0.0.5 milestone Apr 7, 2023
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #17 (37cd5c3) into main (c90deba) will increase coverage by 0.37%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   90.98%   91.36%   +0.37%     
==========================================
  Files          42       42              
  Lines        3205     3207       +2     
  Branches      641      641              
==========================================
+ Hits         2916     2930      +14     
+ Misses        215      202      -13     
- Partials       74       75       +1     
Flag Coverage Δ
unittests 91.20% <100.00%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/xoscar/constants.py 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aresnow1 aresnow1 merged commit a66fafd into xorbitsai:main Apr 7, 2023
@qianduoduo0904 qianduoduo0904 deleted the enh/tempdir branch April 7, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants