Skip to content

BUG: conflict socket dir when multiple users on the same machine #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2023

Conversation

ChengjieLi28
Copy link
Contributor

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the bug Something isn't working label Apr 4, 2023
@XprobeBot XprobeBot added this to the v0.0.3 milestone Apr 4, 2023
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Merging #16 (0d5fd84) into main (3dc13a0) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   90.98%   90.98%   -0.01%     
==========================================
  Files          42       42              
  Lines        3207     3205       -2     
  Branches      641      641              
==========================================
- Hits         2918     2916       -2     
  Misses        215      215              
  Partials       74       74              
Flag Coverage Δ
unittests 90.82% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/xoscar/backends/communication/socket.py 96.74% <ø> (-0.05%) ⬇️
python/xoscar/constants.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@qianduoduo0904 qianduoduo0904 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XprobeBot XprobeBot modified the milestones: v0.0.3, v0.0.4 Apr 4, 2023
Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aresnow1 aresnow1 merged commit c90deba into xorbitsai:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants