Skip to content

ENH: use /tmp/xoscar as default temp dir #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 31, 2023

Conversation

UranusSeven
Copy link
Contributor

What do these changes do?

Use /tmp/xoscar as default temp dir

Related issue number

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the enhancement New feature or request label Mar 23, 2023
@XprobeBot XprobeBot added this to the v0.0.3 milestone Mar 23, 2023
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #13 (c96d5f2) into main (6fe27a1) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   91.02%   90.98%   -0.04%     
==========================================
  Files          41       42       +1     
  Lines        3199     3207       +8     
  Branches      641      641              
==========================================
+ Hits         2912     2918       +6     
- Misses        214      215       +1     
- Partials       73       74       +1     
Flag Coverage Δ
unittests 90.83% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/xoscar/backends/communication/socket.py 96.78% <100.00%> (-0.87%) ⬇️
python/xoscar/constants.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@qianduoduo0904
Copy link
Contributor

I am just curious that if it's possible to use the user directory, e.g. ~/xoscar ? and the permission error would not happen in this situation.

@UranusSeven
Copy link
Contributor Author

I am just curious that if it's possible to use the user directory, e.g. ~/xoscar ? and the permission error would not happen in this situation.

For a standalone deployment, i.e. an xoscar cluster starts from command line, ~/xoscar is OK. But for an embedded deployment, like in Xorbits where user may start an Xorbits local cluster under any dir, you may want a fixed dir for temp files.

@qianduoduo0904
Copy link
Contributor

I am just curious that if it's possible to use the user directory, e.g. ~/xoscar ? and the permission error would not happen in this situation.

For a standalone deployment, i.e. an xoscar cluster starts from command line, ~/xoscar is OK. But for an embedded deployment, like in Xorbits where user may start an Xorbits local cluster under any dir, you may want a fixed dir for temp files.

Got it.

Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aresnow1 aresnow1 merged commit 3dc13a0 into xorbitsai:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants