Skip to content

ENH: do not use global variable for profiling #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

qianduoduo0904
Copy link
Contributor

What do these changes do?

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the enhancement New feature or request label Mar 16, 2023
@XprobeBot XprobeBot added this to the v0.1.0 milestone Mar 16, 2023
@qianduoduo0904 qianduoduo0904 marked this pull request as ready for review March 16, 2023 13:28
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #11 (dea9569) into main (0d7e1ac) will decrease coverage by 43.18%.
The diff coverage is 75.00%.

@@             Coverage Diff             @@
##             main      #11       +/-   ##
===========================================
- Coverage   91.02%   47.85%   -43.18%     
===========================================
  Files          41       41               
  Lines        3188     3197        +9     
  Branches      638      328      -310     
===========================================
- Hits         2902     1530     -1372     
- Misses        213     1634     +1421     
+ Partials       73       33       -40     
Flag Coverage Δ
unittests 47.85% <75.00%> (-43.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/xoscar/backends/core.py 25.27% <50.00%> (-70.29%) ⬇️
python/xoscar/profiling.py 43.02% <83.33%> (-49.62%) ⬇️

... and 29 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@aresnow1 aresnow1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aresnow1 aresnow1 merged commit 7d8fe61 into xorbitsai:main Mar 17, 2023
@qianduoduo0904 qianduoduo0904 deleted the fix/profiling branch March 17, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants