Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add include_groups parameter into groupby.apply #841

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

hainaweiben
Copy link
Collaborator

What do these changes do?

  • Add include_groups field to GroupByApply class
  • Update groupby_apply function signature and documentation
  • Modify execute method to handle the new parameter

Related issue number

Fixes #xxxx

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass

@XprobeBot XprobeBot added the enhancement New feature or request label Jan 12, 2025
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.54%. Comparing base (081d5f9) to head (1257663).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #841       +/-   ##
===========================================
+ Coverage   69.29%   81.54%   +12.24%     
===========================================
  Files        1071     1071               
  Lines       80149    80153        +4     
  Branches    12201    12202        +1     
===========================================
+ Hits        55537    65358     +9821     
+ Misses      22649    13256     -9393     
+ Partials     1963     1539      -424     
Flag Coverage Δ
unittests 81.43% <ø> (+12.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hainaweiben
Copy link
Collaborator Author

Changes were made referencing Deprecation Warning with groupby.apply.

It's important to note that the groupby parameter include_groups is slated for deprecation:

Deprecated since version 2.2.0: Setting include_groups to True is deprecated. Only the value False will be allowed in a future version of pandas.

Please take this into account during review, and we may need to plan further updates to accommodate future versions of pandas.

@luweizheng luweizheng changed the title ENH: Add include_groups parameter to handle deprecated groupby.apply behavior ENH: Add include_groups parameter into groupby.apply Jan 13, 2025
Copy link
Collaborator

@luweizheng luweizheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luweizheng luweizheng merged commit d458b8b into xorbitsai:main Jan 13, 2025
20 of 23 checks passed
@hainaweiben hainaweiben deleted the fix/groupby-apply-deprecation branch January 13, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants