Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop netcoreapp3.1 target #685

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Drop netcoreapp3.1 target #685

merged 1 commit into from
Dec 20, 2022

Conversation

iamcarbon
Copy link
Contributor

This PR drops support for the netcoreapp3.1 target (now out of support).

.netcoreapp3.1 will get the netstandard2.1 target after this update.

@coveralls
Copy link

coveralls commented Dec 17, 2022

Pull Request Test Coverage Report for Build 3718428439

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.292%

Totals Coverage Status
Change from base Build 3614357950: 0.0%
Covered Lines: 25918
Relevant Lines: 27173

💛 - Coveralls

@omer-iqbal
Copy link

Hi,

It might also help readers if the readme.md at root is updated which lists the compatible frameworks.

Thx

@iamcarbon
Copy link
Contributor Author

@omer-iqbal The library continues to support ALL supported .NET frameworks -- and this PR does not change that. The netstandard2.1 target allows the library to continue to be used by netcoreapp3.1.

Nuget does a great job at showing the libraries compatibility: https://www.nuget.org/packages/Markdig

@xoofx xoofx merged commit 25323f0 into xoofx:master Dec 20, 2022
@xoofx
Copy link
Owner

xoofx commented Dec 20, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants