feat: linter should error on new empty resolver tests

xolvio · Aug 22, 2023 · 6ff9c4e · 6ff9c4e
1 parent ab046a0
commit 6ff9c4e
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 23 deletions.
diff --git a/scaffold/.eslintrc b/scaffold/.eslintrc
@@ -15,36 +15,25 @@
     "plugin:@typescript-eslint/recommended",
     "plugin:prettier/recommended"
   ],
-  "plugins": [
-    "@typescript-eslint",
-    "import"
-  ],
+  "plugins": ["@typescript-eslint", "import"],
   "rules": {
     "import/no-extraneous-dependencies": [
       "error",
       {
-        "devDependencies": [
-          "**/*.test.ts",
-          "**/*.spec.ts"
-        ]
+        "devDependencies": ["**/*.test.ts", "**/*.spec.ts"]
       }
     ],
     "import/prefer-default-export": 0,
     "no-underscore-dangle": 0,
-    "no-cond-assign": [
-      "error",
-      "except-parens"
-    ],
+    "no-cond-assign": ["error", "except-parens"],
     "import/no-cycle": 0,
     "@typescript-eslint/interface-name-prefix": 0,
     "@typescript-eslint/no-unused-vars": 1,
     "@typescript-eslint/naming-convention": [
       "error",
       {
         "selector": "default",
-        "format": [
-          "camelCase"
-        ]
+        "format": ["camelCase"]
       },
       {
         "selector": "variable",
@@ -54,19 +43,21 @@
           "match": true
         }
       },
+      {
+        "selector": "property",
+        "format": null,
+        "filter": {
+          "regex": ".*(typename)$",
+          "match": true
+        }
+      },
       {
         "selector": "variable",
-        "format": [
-          "camelCase",
-          "UPPER_CASE",
-          "PascalCase"
-        ]
+        "format": ["camelCase", "UPPER_CASE", "PascalCase"]
       },
       {
         "selector": "typeLike",
-        "format": [
-          "PascalCase"
-        ]
+        "format": ["PascalCase"]
       }
     ]
   },
@@ -76,6 +67,19 @@
       "rules": {
         "@typescript-eslint/naming-convention": "off"
       }
+    },
+    {
+      "files": ["src/**/*.spec.ts", "src/**/*.test.ts"],
+      "plugins": ["jest"],
+      "extends": ["plugin:jest/recommended"],
+      "rules": {
+        "jest/expect-expect": [
+          "error",
+          {
+            "assertFunctionNames": ["expect", "td.verify"]
+          }
+        ]
+      }
     }
   ],
   "env": {

diff --git a/scaffold/package.json b/scaffold/package.json
@@ -54,6 +54,7 @@
     "eslint-config-prettier": "8.10.0",
     "eslint-import-resolver-typescript": "3.5.5",
     "eslint-plugin-import": "2.28.0",
+    "eslint-plugin-jest": "^27.2.3",
     "eslint-plugin-prettier": "5.0.0",
     "jest": "29.6.2",
     "lint-staged": "10.2.11",