Made concealing configurable #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 6, 2015 13:27
Users can now add options to configure whether or not the conceal
feature isused to shorten urls and hide quotes/underscores for
formatting. To disable all concealing:
let g:notes_coneal_code = 0
let g:notes_coneal_italics = 0
let g:notes_coneal_bold = 0
let g:notes_coneal_url = 0
This was added because some plugins don't play nicely with concealing.
In particular, the indentLines plugin is conflicting with coneal on OSX
(at least).
xolox
added a commit
that referenced
this pull request
Mar 15, 2015
I made a few changes while merging this pull request: 1. I changed the logic inside syntax/notes.vim to use the function xolox#misc#option#get() with a default option value of true (1). In my mind this makes a lot more sense than checking for the existence of variables without checking their actual values. 2. I renamed notes_conceal_italics to notes_conceal_italic to be consistent with the other options (IMHO). 3. I rewrote the documentation additions because A) doc/notes.txt is generated from README.md so the changes by @naddeoa would have gone lost and B) because there were typos in the additions (s/coneal/conceal/g). 4. The documentation for notes_conceal_code was incorrect because the code changes by @naddeoa only apply to the markers for inline code fragments, not the markers for multi line code blocks. I kept the implementation as is and updated the documentation to match the implementation. See also pull request 104 on GitHub: #104
|
Hi Anthony and thanks for the contribution! I've merged your pull request but had to make a few changes while merging:
Happy Vimming! |
|
Thanks a lot, and good catches, I need to be more careful before issuing pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.