Allow correct behavior of 'parse_size' and 'format_size' #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xolox
added a commit
that referenced
this pull request
Sep 29, 2016
xolox
added a commit
that referenced
this pull request
Sep 29, 2016
Owner
|
Hi Daniel and thanks for this pull request! I merged your changes but then decided to iterate further, switch the default to powers of ten and make improvements to the parsing code. More details available here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintain default behavior (for semantic versioning), but provide an option for people who want file sizes handled in base 10 instead of base 2. Would require a minor version bump.