-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip pyreadline dependency on Windows with Python 3.9+ #45
skip pyreadline dependency on Windows with Python 3.9+ #45
Conversation
CI seems to be failing for unrelated reasons already on the target branch. I created #46 to address these linter warnings. Once that got merged I can rebase this patch to hopefully also pass CI. |
@xolox FYI |
@xolox Friendly ping. |
This is to fix our Windows builds until xolox/python-humanfriendly#45 is resolved. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
The deprecated aliases have now been removed from Python as of 3.10 alpha 5 (see python/cpython#23754), so this is now a hard error. |
You could also consider adding a dependency on (I'm currently seeing this warning because |
@xolox Friendly ping |
I'm going to merge the changes provided by @dirk-thomas in this pull request but will incorporate the suggestion @KyleKing made in #45 (comment) because it sounds like this should result in the best of both worlds. |
Hi all, Thanks for the feedback and sorry it took me so long to resolve this. I think this issue should now be resolved with the release of humanfriendly 10.0, because I merged the changes suggested by this pull request and then also incorporated the However I don't have access to a Windows environment for testing, so if anyone can confirm that would be great 😅. |
`Release 10.0`_ (2021-09-17) ---------------------------- **Noteworthy changes:** - Merged pull request `openembedded#45`_ to resolve the issue caused by the conditional :pypi:`pyreadline` requirement on Windows not supporting Python 3.9+. - Updated the readme to use Python 3 in the example (reported in issue `openembedded#56`_). Also added a mention of the ``humanfriendly --demo`` command. - Removed the ``humanfriendly.compat.unittest`` alias that presumably no-one is using at this point; it had been rendered useless quite a long time ago (requested in issue `openembedded#53`_). **Internal changes:** - Merged pull request `openembedded#54`_ which migrates the :pypi:`humanfriendly` project from Travis CI to GitHub Actions and from Coveralls.io to Codecov. - Fixed a deprecation warning concerning ``setup.cfg`` and some Sphinx documentation errors. .. _Release 10.0: xolox/python-humanfriendly@9.2...10.0 .. _#45: xolox/python-humanfriendly#45 .. _#53: xolox/python-humanfriendly#53 .. _#54: xolox/python-humanfriendly#54 .. _#56: xolox/python-humanfriendly#56 Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
`Release 10.0`_ (2021-09-17) ---------------------------- **Noteworthy changes:** - Merged pull request `openembedded#45`_ to resolve the issue caused by the conditional :pypi:`pyreadline` requirement on Windows not supporting Python 3.9+. - Updated the readme to use Python 3 in the example (reported in issue `openembedded#56`_). Also added a mention of the ``humanfriendly --demo`` command. - Removed the ``humanfriendly.compat.unittest`` alias that presumably no-one is using at this point; it had been rendered useless quite a long time ago (requested in issue `openembedded#53`_). **Internal changes:** - Merged pull request `openembedded#54`_ which migrates the :pypi:`humanfriendly` project from Travis CI to GitHub Actions and from Coveralls.io to Codecov. - Fixed a deprecation warning concerning ``setup.cfg`` and some Sphinx documentation errors. .. _Release 10.0: xolox/python-humanfriendly@9.2...10.0 .. _#45: xolox/python-humanfriendly#45 .. _#53: xolox/python-humanfriendly#53 .. _#54: xolox/python-humanfriendly#54 .. _#56: xolox/python-humanfriendly#56 Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
`Release 10.0`_ (2021-09-17) ---------------------------- **Noteworthy changes:** - Merged pull request `openembedded#45`_ to resolve the issue caused by the conditional :pypi:`pyreadline` requirement on Windows not supporting Python 3.9+. - Updated the readme to use Python 3 in the example (reported in issue `openembedded#56`_). Also added a mention of the ``humanfriendly --demo`` command. - Removed the ``humanfriendly.compat.unittest`` alias that presumably no-one is using at this point; it had been rendered useless quite a long time ago (requested in issue `openembedded#53`_). **Internal changes:** - Merged pull request `openembedded#54`_ which migrates the :pypi:`humanfriendly` project from Travis CI to GitHub Actions and from Coveralls.io to Codecov. - Fixed a deprecation warning concerning ``setup.cfg`` and some Sphinx documentation errors. .. _Release 10.0: xolox/python-humanfriendly@9.2...10.0 .. _#45: xolox/python-humanfriendly#45 .. _#53: xolox/python-humanfriendly#53 .. _#54: xolox/python-humanfriendly#54 .. _#56: xolox/python-humanfriendly#56 Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
`Release 10.0`_ (2021-09-17) ---------------------------- **Noteworthy changes:** - Merged pull request `openembedded#45`_ to resolve the issue caused by the conditional :pypi:`pyreadline` requirement on Windows not supporting Python 3.9+. - Updated the readme to use Python 3 in the example (reported in issue `openembedded#56`_). Also added a mention of the ``humanfriendly --demo`` command. - Removed the ``humanfriendly.compat.unittest`` alias that presumably no-one is using at this point; it had been rendered useless quite a long time ago (requested in issue `openembedded#53`_). **Internal changes:** - Merged pull request `openembedded#54`_ which migrates the :pypi:`humanfriendly` project from Travis CI to GitHub Actions and from Coveralls.io to Codecov. - Fixed a deprecation warning concerning ``setup.cfg`` and some Sphinx documentation errors. .. _Release 10.0: xolox/python-humanfriendly@9.2...10.0 .. _#45: xolox/python-humanfriendly#45 .. _#53: xolox/python-humanfriendly#53 .. _#54: xolox/python-humanfriendly#54 .. _#56: xolox/python-humanfriendly#56 Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
`Release 10.0`_ (2021-09-17) ---------------------------- **Noteworthy changes:** - Merged pull request `openembedded#45`_ to resolve the issue caused by the conditional :pypi:`pyreadline` requirement on Windows not supporting Python 3.9+. - Updated the readme to use Python 3 in the example (reported in issue `openembedded#56`_). Also added a mention of the ``humanfriendly --demo`` command. - Removed the ``humanfriendly.compat.unittest`` alias that presumably no-one is using at this point; it had been rendered useless quite a long time ago (requested in issue `openembedded#53`_). **Internal changes:** - Merged pull request `openembedded#54`_ which migrates the :pypi:`humanfriendly` project from Travis CI to GitHub Actions and from Coveralls.io to Codecov. - Fixed a deprecation warning concerning ``setup.cfg`` and some Sphinx documentation errors. .. _Release 10.0: xolox/python-humanfriendly@9.2...10.0 .. _#45: xolox/python-humanfriendly#45 .. _#53: xolox/python-humanfriendly#53 .. _#54: xolox/python-humanfriendly#54 .. _#56: xolox/python-humanfriendly#56 Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com>
`Release 10.0`_ (2021-09-17) ---------------------------- **Noteworthy changes:** - Merged pull request `#45`_ to resolve the issue caused by the conditional :pypi:`pyreadline` requirement on Windows not supporting Python 3.9+. - Updated the readme to use Python 3 in the example (reported in issue `#56`_). Also added a mention of the ``humanfriendly --demo`` command. - Removed the ``humanfriendly.compat.unittest`` alias that presumably no-one is using at this point; it had been rendered useless quite a long time ago (requested in issue `#53`_). **Internal changes:** - Merged pull request `#54`_ which migrates the :pypi:`humanfriendly` project from Travis CI to GitHub Actions and from Coveralls.io to Codecov. - Fixed a deprecation warning concerning ``setup.cfg`` and some Sphinx documentation errors. .. _Release 10.0: xolox/python-humanfriendly@9.2...10.0 .. _#45: xolox/python-humanfriendly#45 .. _#53: xolox/python-humanfriendly#53 .. _#54: xolox/python-humanfriendly#54 .. _#56: xolox/python-humanfriendly#56 Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
`Release 10.0`_ (2021-09-17) ---------------------------- **Noteworthy changes:** - Merged pull request `#45`_ to resolve the issue caused by the conditional :pypi:`pyreadline` requirement on Windows not supporting Python 3.9+. - Updated the readme to use Python 3 in the example (reported in issue `#56`_). Also added a mention of the ``humanfriendly --demo`` command. - Removed the ``humanfriendly.compat.unittest`` alias that presumably no-one is using at this point; it had been rendered useless quite a long time ago (requested in issue `#53`_). **Internal changes:** - Merged pull request `#54`_ which migrates the :pypi:`humanfriendly` project from Travis CI to GitHub Actions and from Coveralls.io to Codecov. - Fixed a deprecation warning concerning ``setup.cfg`` and some Sphinx documentation errors. .. _Release 10.0: xolox/python-humanfriendly@9.2...10.0 .. _#45: xolox/python-humanfriendly#45 .. _#53: xolox/python-humanfriendly#53 .. _#54: xolox/python-humanfriendly#54 .. _#56: xolox/python-humanfriendly#56 Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
`Release 10.0`_ (2021-09-17) ---------------------------- **Noteworthy changes:** - Merged pull request `#45`_ to resolve the issue caused by the conditional :pypi:`pyreadline` requirement on Windows not supporting Python 3.9+. - Updated the readme to use Python 3 in the example (reported in issue `#56`_). Also added a mention of the ``humanfriendly --demo`` command. - Removed the ``humanfriendly.compat.unittest`` alias that presumably no-one is using at this point; it had been rendered useless quite a long time ago (requested in issue `#53`_). **Internal changes:** - Merged pull request `#54`_ which migrates the :pypi:`humanfriendly` project from Travis CI to GitHub Actions and from Coveralls.io to Codecov. - Fixed a deprecation warning concerning ``setup.cfg`` and some Sphinx documentation errors. .. _Release 10.0: xolox/python-humanfriendly@9.2...10.0 .. _#45: xolox/python-humanfriendly#45 .. _#53: xolox/python-humanfriendly#53 .. _#54: xolox/python-humanfriendly#54 .. _#56: xolox/python-humanfriendly#56 Signed-off-by: Zheng Ruoqin <zhengrq.fnst@fujitsu.com> Signed-off-by: Khem Raj <raj.khem@gmail.com> Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
Fixes #44
Since
pyreadline
doesn't support Python 3.9 and isn't being maintained at the moment this patch makes the dependency conditional based on the Python version. Additionally the import of the module is allowed to fail.