Replace pipes.quote with shlex.quote on Python 3 #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The shlex.quote() API is available from Python 3.3 on; pipes.quote() was never documented, and is removed in Python 3.13. Fixes xolox#119.
|
When xolox/python-humanfriendly#75 is also applied, all tests pass on Python 3.13. |
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jun 30, 2024
It was necessary to apply patch [1] in order to make py3.13 work. [1] xolox/python-coloredlogs#120 Signed-off-by: Petr Vaněk <arkamar@gentoo.org>
|
When will this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shlex.quote() API is available from Python 3.3 on; pipes.quote() was never documented, and is removed in Python 3.13.
Fixes #119.