Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python 3.7? #65

Closed
ebuildy opened this issue Jan 25, 2019 · 6 comments
Closed

Support Python 3.7? #65

ebuildy opened this issue Jan 25, 2019 · 6 comments

Comments

@ebuildy
Copy link

ebuildy commented Jan 25, 2019

Wondering why this is not supporting Python 3.7 ?
@mcepl
Copy link

mcepl commented Jan 31, 2019

What errors you have when it fails?

@mr-c
Copy link

mr-c commented May 1, 2019

./scripts/generate-screenshots.py:130:33: W606 'async' and 'await' are reserved keywords starting with Python 3.7

@hugovk
Copy link
Contributor

hugovk commented Feb 15, 2020

3.7 support was added in 9be1013 (3.8 could also be added). Can you reproduce the error in the newest release?

@mr-c
Copy link

mr-c commented Feb 15, 2020

From a fresh checkout

$ make screenshots 
Already using interpreter /usr/bin/python3
Traceback (most recent call last):
  File "scripts/generate-screenshots.py", line 45, in <module>
    from capturer import CaptureOutput
ModuleNotFoundError: No module named 'capturer'
make: *** [Makefile:62: screenshots] Error 1

@xolox
Copy link
Owner

xolox commented Feb 15, 2020

As of coloredlogs 11.0 (released yesterday) Python 3.7 is official supported:

  • Older coloredlogs releases implicitly supported Python 3.7 already.
  • The main thing I fixed yesterday was to add a workaround to the test suite for what I believe to be a regression in Python 3.7, for details on that refer to [Failing test] ColoredLogsTestCase.test_plain_text_output_format #66. Given that this concerns a regression in interpreter behavior for an obscure edge case in the test suite, it was never a real incompatibility.
  • The flake8 warnings mentioned above were fixed when Fix Flake8 #60 was merged.
  • In any case make screenshots (scripts/generate-screenshots.py) generates screenshots which are also included in the version control repository. There's no reason for anyone but the project maintainer (me) to actually use this script. This explains why I didn't bother to properly document the additional dependencies.

In any case yesterday I also updated the Makefile to use Python 3 for local development and since then I noticed that scripts/generate-screenshots.py doesn't actually work on Python 3, so I will fix those incompatibilities and also document the additional Python installation requirements.

xolox added a commit that referenced this issue Feb 15, 2020
@xolox
Python 3 compatibility for 'make screenshots' (#65)
e207250
xolox added a commit that referenced this issue Feb 15, 2020
@xolox
Document 'make screenshots' dependencies (#65)
b63fce3
@xolox
Copy link
Owner

xolox commented Feb 15, 2020

I'm going to close this issue now, given the rationale above and the commits since then.

@xolox xolox closed this as completed Feb 15, 2020
xolox added a commit that referenced this issue Feb 15, 2020
@xolox
Release 11.1: Fix support for custom log record factories (#59, #65)
b929c0b
bors bot added a commit to duckinator/bork that referenced this issue Feb 16, 2020
@bors @pyup-bot
Merge #112
0f977b3 
112: Update coloredlogs to 12.0 r=duckinator a=pyup-bot


This PR updates [coloredlogs](https://pypi.org/project/coloredlogs) from **11.0** to **12.0**.



<details>
  <summary>Changelog</summary>
  
  
   ### 12.0
   ```
   ----------------------------

Two backwards incompatible changes prompted another major version bump:

- Merged pull request `80`_ that drops support for Python 3.4 which
  has gone end-of-life and now represents less than 1% of PyPI downloads.

- Improved compatibility with the Python standard library by changing
  the order of positional arguments received by the initializer of the
  :class:`~coloredlogs.ColoredFormatter` class (as suggested in `64`_
  and `75`_).

.. _Release 12.0: xolox/python-coloredlogs@11.3...12.0
.. _80: xolox/python-coloredlogs#80
.. _64: xolox/python-coloredlogs#64
.. _75: xolox/python-coloredlogs#75
   ```
   
  
  
   ### 11.3
   ```
   ----------------------------

- Add support for the ``%(username)s`` field (requested in `76`_) and properly
  document supported custom fields.

- Consistently use ``console`` highlighting in documentation.

- Fix a broken link in the readme.

.. _Release 11.3: xolox/python-coloredlogs@11.2...11.3
.. _76: xolox/python-coloredlogs#76
   ```
   
  
  
   ### 11.2
   ```
   ----------------------------

Merge pull request `79`_ which adds support for Python 3.8.

.. _Release 11.2: xolox/python-coloredlogs@11.1...11.2
.. _79: xolox/python-coloredlogs#79
   ```
   
  
  
   ### 11.1
   ```
   ----------------------------

Starting with the previous release I&#39;ve resolved to try and tackle the large
number of open issues after an unplanned hiatus from the development and
maintenance of my open source projects, so here are some more bug fixes:

- Fix support for custom log record factories and add a test to avoid
  regressions (`47`_, `59`_).

- Change ``make screenshots`` to be Python 3 compatible and document
  additional requirements (`65`_).

.. _Release 11.1: xolox/python-coloredlogs@11.0...11.1
.. _59: xolox/python-coloredlogs#59
.. _65: xolox/python-coloredlogs#65
   ```
   
  
</details>


 

<details>
  <summary>Links</summary>
  
  - PyPI: https://pypi.org/project/coloredlogs
  - Changelog: https://pyup.io/changelogs/coloredlogs/
  - Docs: https://coloredlogs.readthedocs.io
</details>



Co-authored-by: pyup-bot <github-bot@pyup.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@xolox @mcepl @ebuildy @hugovk @mr-c