Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't override rules from user's config #761

Merged
merged 4 commits into from
Jul 23, 2024
Merged

fix: Don't override rules from user's config #761

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f6506fe
fix: Don't override `n/no-unsupported-features/*` if user has customi…
melusc Jul 20, 2024
1c43569
Assert it doesn't throw on `index.js`, but does still throw on `overr…
melusc Jul 20, 2024
8bdc3b3
Rename test to be more general
melusc Jul 22, 2024
752e01a
Use nullish assignment for all rules to respect user's config
melusc Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename test to be more general
  • Loading branch information
@melusc
melusc committed Jul 22, 2024
commit 8bdc3b34a8aa7aff3ded204cd6514dafb5b7c6aa
4 changes: 2 additions & 2 deletions test/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,8 +198,8 @@ test('print-config flag without filename', async t => {
t.is(error.stderr.trim(), 'The `--print-config` flag must be used with exactly one filename');
});

test('Disable n/no-unsupported-features/*', async t => {
const cwd = path.join(__dirname, 'fixtures/disable-n-no-unsupported-features');
test('Do not override user-config', async t => {
const cwd = path.join(__dirname, 'fixtures/no-override-user-config');
const {stdout} = await main(['--print-config', 'index.js'], {cwd});
const config = JSON.parse(stdout);
t.like(config, {
Expand Down
0 ...isable-n-no-unsupported-features/index.js → ...fixtures/no-override-user-config/index.js
View file
Open in desktop
File renamed without changes.
0 ...le-n-no-unsupported-features/overrides.js → ...ures/no-override-user-config/overrides.js
View file
Open in desktop
File renamed without changes.
0 ...le-n-no-unsupported-features/package.json → ...ures/no-override-user-config/package.json
View file
Open in desktop
File renamed without changes.