Verbose flag implementation #365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Norris1z
changed the title
Norris1z
force-pushed
the
add_verbose_flag
branch
2 times, most recently
from
ff49fbc to
359ae11
Compare
|
This seems to be missing:
|
|
Instead of reimplementing the logic, I think it would be better to just put the logging right next to where the different things are created, for example, the resolved config could be logged where XO finishes resolving the config. |
Norris1z
force-pushed
the
add_verbose_flag
branch
from
dba1c42 to
068901e
Compare
|
@sindresorhus files/paths in the |
|
The travis builds passed but i don't know why this is still stuck at |
sindresorhus
force-pushed
the
master
branch
2 times, most recently
from
9bbe1bf to
2ab0a69
Compare
|
Given the age I'm going to close this PR, but it's definitely still a welcome change. Please open a new PR if you intend to work on it again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a basic implementation of the
--verboseflag which is a fix #188