fix(oracle): use view available for all users for driver.Version #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenshaw
reviewed
May 2, 2025
|
@murfffi can you please also modify |
Use v$version instead of v$instance because it is available to all users. Like v$instance, v$version is available in all oracle versions from the past 20+ years. Typical Version() output is "Oracle Database 21c Express Edition Release 21.0.0.0.0 - Production" Testing Done: Oracle Express 21c and 11g For 11g: docker run -d -p 1521:1521 -e ORACLE_PASSWORD=foobar gvenzl/oracle-xe:11-slim ./usql oracle://sys:foobar@localhost/xe # version is shown correctly create user test identified by test; GRANT CREATE SESSION to test; \connect oracle://test:test@localhost/xe # version is still shown correctly, despite minimal privileges 21c in the issue was also tested that way.
|
Let me know if more changes are needed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #489
Use v$version instead of v$instance because it is available to all users.
Like v$instance, v$version is available in all non-ancient oracle versions.
Both are available in the earliest documentation I could find: 10g, released 2003.
Testing Done: Oracle Express 21c (as in the reported issue) and 11g
For 11g:
21c in the issue was also tested that way.
Also tested with
contrib/usql-test.shusing docker as a workaround for oracle/docker-images#2925 .