Skip to content

Update to xmtp rn sdk 4.2.5#88

Merged
nplasterer merged 1 commit intomainfrom
np/fork-fixes
Jun 27, 2025
Merged

Update to xmtp rn sdk 4.2.5#88
nplasterer merged 1 commit intomainfrom
np/fork-fixes

Conversation

@nplasterer
Copy link
Contributor

@nplasterer nplasterer commented Jun 27, 2025

Major fork fixes

Summary by CodeRabbit

  • Chores
    • Updated the "@xmtp/react-native-sdk" dependency to the latest version.
    • Increased the version of the XMTP pod dependency for the iOS notification service extension.

@nplasterer nplasterer self-assigned this Jun 27, 2025
@nplasterer nplasterer requested a review from a team as a code owner June 27, 2025 01:05
@macroscopeapp
Copy link

macroscopeapp bot commented Jun 27, 2025

Update XMTP React Native SDK from version 4.2.3 to 4.2.5 and align iOS pod version from 4.2.1 to 4.2.3

Updates the @xmtp/react-native-sdk dependency version and aligns the corresponding iOS notification service extension pod version to maintain compatibility.

  • Updates @xmtp/react-native-sdk dependency from version 4.2.3 to 4.2.5 in package.json
  • Updates XMTP iOS pod version from 4.2.1 to 4.2.3 in the notification service extension configuration in with-my-plugin-ios.ts
  • Updates dependency lock file yarn.lock to reflect the version changes

📍Where to Start

Start with the dependency version update in package.json to understand the primary change, then review the corresponding iOS pod version alignment in with-my-plugin-ios.ts.


Macroscope summarized 4045ee2.

@coderabbitai
Copy link

coderabbitai bot commented Jun 27, 2025

Walkthrough

This change updates the @xmtp/react-native-sdk dependency in package.json from version ^4.2.3 to ^4.2.5 and synchronizes the XMTP CocoaPod version in the iOS notification service extension from 4.2.1 to 4.2.3. No other logic or configuration changes are present.

Changes

File(s) Change Summary
package.json Updated @xmtp/react-native-sdk dependency from ^4.2.3 to ^4.2.5
plugins/.../with-my-plugin-ios.ts Updated XMTP pod version in notification extension from 4.2.1 to 4.2.3

Possibly related PRs

Suggested reviewers

  • lourou

Poem

A hop, a skip, a version bump,
New SDKs to clear the hump.
Pods align, the numbers grow,
Dependencies in tidy row.
With every change, the code feels spry—
A rabbit’s leap, and off we fly! 🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
plugins/notification-service-extension/plugin/src/with-my-plugin-ios.ts (1)

260-264: ```shell
#!/bin/bash

Search for any occurrences of the XMTP Pod declaration across the repo

grep -R --line-number "pod 'XMTP'" .

Verify the installed JS SDK version in package.json

grep -R --line-number '"@xmtp/react-native-sdk"' .

Check for any references to version 4.2.5 in the codebase

grep -R --line-number "4\.2\.5" .


</blockquote></details>

</blockquote></details>

<details>
<summary>📜 Review details</summary>

**Configuration used: CodeRabbit UI**
**Review profile: CHILL**
**Plan: Pro**


<details>
<summary>📥 Commits</summary>

Reviewing files that changed from the base of the PR and between 741874e4750c5a4b5d32f97a497c3d0432817bc0 and 4045ee22298e06c559c4c3983998505b38a3ebb0.

</details>

<details>
<summary>⛔ Files ignored due to path filters (1)</summary>

* `yarn.lock` is excluded by `!**/yarn.lock`, `!**/*.lock`

</details>

<details>
<summary>📒 Files selected for processing (2)</summary>

* `package.json` (1 hunks)
* `plugins/notification-service-extension/plugin/src/with-my-plugin-ios.ts` (1 hunks)

</details>

<details>
<summary>🧰 Additional context used</summary>

<details>
<summary>📓 Path-based instructions (2)</summary>

<details>
<summary>`**/*`: Use lower-kebab-case for directories and files.
Use descriptive suffixes...</summary>


> `**/*`: Use lower-kebab-case for directories and files.
> Use descriptive suffixes for files that indicate their purpose, such as .screen.tsx, .nav.tsx, .store.ts, .query.ts, .utils.ts, .types.ts, .test.ts.
> Name files with the feature name as prefix and a descriptive suffix indicating the file's purpose (e.g., [featureName].screen.tsx).
> Follow the feature-based organization pattern: group files by feature, and keep related files together.
> Place files as close as possible to where they are used.
> Import paths should start with @/.

📄 Source: CodeRabbit Inference Engine (.cursor/rules/file-structure.mdc)

List of files the instruction was applied to:
- `package.json`
- `plugins/notification-service-extension/plugin/src/with-my-plugin-ios.ts`

</details>
<details>
<summary>`**/*.ts`: Use types (prefixed with 'I') instead of interfaces.
Never use 'any' ...</summary>


> `**/*.ts`: Use types (prefixed with 'I') instead of interfaces.
> Never use 'any' as a type.
> Do not use enums; use string literal union types instead.
> Prefer type inference when possible instead of explicit type annotations.
> Avoid explicit Promise return types; let TypeScript infer them.
> Prefer type assertions on return objects (e.g., 'satisfies') over function return type annotations.
> Avoid explicit return types on functions; let TypeScript infer them.

📄 Source: CodeRabbit Inference Engine (.cursor/rules/typescript.mdc)

List of files the instruction was applied to:
- `plugins/notification-service-extension/plugin/src/with-my-plugin-ios.ts`

</details>

</details><details>
<summary>🧠 Learnings (2)</summary>

<details>
<summary>📓 Common learnings</summary>

Learnt from: CR
PR: ephemeraHQ/convos-app#0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2025-06-27T01:06:49.688Z
Learning: This project is a Chat app that uses the XMTP messaging protocol; ensure that any messaging-related code adheres to XMTP standards and integrates with the protocol correctly.


</details>
<details>
<summary>package.json (1)</summary>

Learnt from: CR
PR: ephemeraHQ/convos-app#0
File: .cursor/rules/library-usage.mdc:0-0
Timestamp: 2025-06-27T01:06:55.120Z
Learning: Before implementing features or fixing issues related to third-party libraries, check the package.json to confirm the library version in use.


</details>

</details>

</details>

<details>
<summary>🔇 Additional comments (1)</summary><blockquote>

<details>
<summary>package.json (1)</summary>

`88-90`: ```shell
#!/bin/bash
# Locate the iOS plugin integration file
fd "with-my-plugin-ios.ts"

# Search for hard-coded XMTP Pod spec versions across the repo
rg "pod 'XMTP'" -n .

@nplasterer nplasterer merged commit 1d1dae1 into main Jun 27, 2025
8 of 9 checks passed
This was referenced Jul 14, 2025
This was referenced Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants