Conversation
|
Caution Review failedThe pull request is closed. ## Walkthrough
The dependency `@xmtp/react-native-sdk` in the `package.json` file was updated from a development build version to a release candidate version. Additionally, the `XMTP` CocoaPod version in the notification service extension Podfile was updated from a development build to the same release candidate version.
## Changes
| File(s) | Change Summary |
|------------------------------------------------|------------------------------------------------------------------------------------------------|
| package.json | Updated `@xmtp/react-native-sdk` from `4.2.0-dev.73f1217` to `4.2.0-rc4` |
| plugins/notification-service-extension/...ios.ts | Updated `XMTP` CocoaPod version from `4.2.0-dev.b10e719` to `4.2.0-rc4` for notification extension |
## Possibly related PRs
- ephemeraHQ/convos-app#52: Updates the `@xmtp/react-native-sdk` dependency to a newer release candidate version.
- ephemeraHQ/convos-app#49: Changes the `@xmtp/react-native-sdk` dependency from a development build to a release candidate version.
- ephemeraHQ/convos-app#57: Modifies the `@xmtp/react-native-sdk` and `XMTP` CocoaPod versions in opposite directions, indicating closely related version management.
## Suggested reviewers
- nplasterer
- cameronvoell
## Poem
> A hop, a skip, a version bump,
> From dev to RC, we take the jump.
> The package grows, the code stays neat,
> With shiny updates, our work’s complete.
> 🐇✨ Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Just noting that there are several things in this release we should probably consume in a follow up PR
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
package.json (1)
88-88: Consider loosening the dependency rangePinning an exact RC version may require manual updates for future patches. You could use a caret to allow non-breaking updates:
- "@xmtp/react-native-sdk": "4.2.0-rc4", + "@xmtp/react-native-sdk": "^4.2.0-rc4",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (1)
package.json(1 hunks)
🔇 Additional comments (1)
package.json (1)
88-88:Details
❓ Verification inconclusive
Verify the new release candidate is published and compatible
Please confirm that version
4.2.0-rc4of@xmtp/react-native-sdkis available in the npm registry and that it integrates properly with the rest of the XMTP ecosystem (e.g.,@xmtp/content-type-primitives).
🏁 Script executed:
#!/bin/bash # Check if the specified version exists in npm npm view @xmtp/react-native-sdk versions --json | jq '. | index("4.2.0-rc4")'Length of output: 83
🏁 Script executed:
#!/bin/bash echo "Peer dependencies for @xmtp/react-native-sdk@4.2.0-rc4:" npm view @xmtp/react-native-sdk@4.2.0-rc4 peerDependencies --json echo "" echo "Dependencies for @xmtp/react-native-sdk@4.2.0-rc4:" npm view @xmtp/react-native-sdk@4.2.0-rc4 dependencies --jsonLength of output: 689
Confirm publication and compatibility of @xmtp/react-native-sdk@4.2.0-rc4
We’ve verified that version
4.2.0-rc4is published on npm (index 265). Below are its peerDependencies and dependencies:• Peer dependencies:
{ "expo": "*", "react": "*", "react-native": "*" }• Dependencies:
{ "@changesets/changelog-git": "^0.2.0", "@changesets/cli": "^2.27.10", "@ethersproject/bytes": "^5.7.0", "@msgpack/msgpack": "^3.0.0-beta2", "@noble/hashes": "^1.3.3", "@xmtp/proto": "3.54.0", "buffer": "^6.0.3", "text-encoding": "^0.7.0" }Please confirm that:
- Your project’s versions of
expo,react, andreact-nativesatisfy the peer requirements.- Any XMTP packages you consume—especially
@xmtp/content-type-primitives—are compatible with@xmtp/proto@3.54.0.- You’ve run an integration test to ensure messaging workflows still function as expected.
|
Just tested locally looks good, think we might need to update this new file as well so that the notif extension uses the updated version as well: |
Macroscope summarized 82a0417. |
4 participants
Update @xmtp/react-native-sdk dependency from version 4.2.0-dev.73f1217 to 4.2.0-rc4
The
@xmtp/react-native-sdkpackage version changes from development version4.2.0-dev.73f1217to release candidate4.2.0-rc4in package.json. The corresponding dependency lock information updates in yarn.lock.📍Where to Start
Start with the dependency version change in package.json.
Macroscope summarized ac8df08.
Summary by CodeRabbit