-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 89.07% 89.85% +0.78%
==========================================
Files 10 12 +2
Lines 293 355 +62
==========================================
+ Hits 261 319 +58
- Misses 32 36 +4 ☔ View full report in Codecov by Sentry. |
Turned out I was using out of date contract, I'm updating this and use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good start. Let me know once it's ready for a final review and I can start and run it and check it out in more detail.
The send message signed should have a multiple message test to confirm nonce is working properly. In general, a few more tests would be great.
Ready for review |
82e3a05
to
99ebdcf
Compare
in light of discussion of #52 can approve |
Just added the |
closes #19