Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payer validation #232

Open
Tracked by #118
neekolas opened this issue Oct 16, 2024 · 0 comments
Open
Tracked by #118

Payer validation #232

neekolas opened this issue Oct 16, 2024 · 0 comments
Assignees

Comments

@neekolas
Copy link
Contributor

No description provided.

neekolas added a commit that referenced this issue Oct 18, 2024
## tl;dr

- Adds method to recover the signer from payer envelopes (#232)
- Refactors domain separation for jwt's and payer envelopes

### AI Assisted Summary

Introduced domain separation for payer signatures, and added functionality to recover signer addresses from payer envelopes.

### What changed?

- Created a new `constants` package with domain separation labels for JWT and payer signatures.
- Updated the JWT signing method to use the new constant for domain separation.
- Implemented a `RecoverSigner` method for `PayerEnvelope` to extract the signer's address.
- Added utility functions for hashing and signing payer envelopes.
- Expanded test coverage for envelope signer recovery.

### Why make this change?

This change enhances security and consistency by introducing domain separation for signatures. It also adds the ability to recover signer addresses from payer envelopes, which is crucial for verifying the authenticity of messages and implementing payer-based features in the system.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant